[GitHub] [incubator-heron] surahman edited a comment on issue #3707: Add support for Pod Templates which are read from a ConfigMap. The ConfigMap name can be passed in as a config-property

[GitBox <gi...@apache.org>]

surahman edited a comment on issue #3707:
URL: https://github.com/apache/incubator-heron/issues/3707#issuecomment-908778398


   Hi @nicknezis, I have started poking around in the code base for `Heron` again and I am trying to wrap my head around what needs to happen here. Again, I do not have any experience in the codebase.
   
   > By providing a Pod Template as a ConfigMap, the Heron Kubernetes Scheduler can retrieve the template and provide it as a base starting point for Pod definition.
   
   This appears to be setting up the `Config` on the Scheduler:
   https://github.com/apache/incubator-heron/blob/4d9a7de106d6f1f6de6a96f996735c5fc636011b/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesScheduler.java#L57-L83
   
   The following code block appears to be creating the YAML config based on the required record structures:
   https://github.com/apache/spark/blob/de59e01aa4853ef951da080c0d1908d53d133ebe/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala#L39-L66
   
   I am trying to figure out what my starting point for this should be on the `Heron` side, any ideas? What functionality is available as far as building the YAML record structures (`Config.Builder`)?
   
   The following utility is preparing the `ConfigMap` and storing the YAML `<Key, Value>` pairs from the `topologyConfig`:
   https://github.com/apache/incubator-heron/blob/4d9a7de106d6f1f6de6a96f996735c5fc636011b/heron/api/src/java/org/apache/heron/api/utils/TopologyUtils.java#L295-L323
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org