You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 15:11:07 UTC
[GitHub] [arrow-rs] carols10cents opened a new pull request #957: Update comfy-table to 5.0
carols10cents opened a new pull request #957:
URL: https://github.com/apache/arrow-rs/pull/957
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #956.
# What changes are included in this PR?
Upgrading comfy-table from 4.0 to 5.0.
# Are there any user-facing changes?
Not that I know of. The [breaking changes in comfy-table](https://github.com/Nukesor/comfy-table/blob/main/CHANGELOG.md#500---2021-11-07) are renaming of some constants that Arrow isn't using. I ran `cargo test --features prettyprint pretty` in `arrow` and all tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #957: Update comfy-table to 5.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #957:
URL: https://github.com/apache/arrow-rs/pull/957#issuecomment-973128187
All the tests are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #957: Update comfy-table to 5.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #957:
URL: https://github.com/apache/arrow-rs/pull/957#issuecomment-972973245
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#957](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e26d369) into [master](https://codecov.io/gh/apache/arrow-rs/commit/32d8c0a022b8a7ef0e86c01b2c4cf573d0501ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32d8c0a) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head e26d369 differs from pull request most recent head 2193d70. Consider uploading reports for the commit 2193d70 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 48715 48715
=======================================
+ Hits 40100 40101 +1
+ Misses 8615 8614 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (ø)` | |
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `85.33% <0.00%> (+0.13%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32d8c0a...2193d70](https://codecov.io/gh/apache/arrow-rs/pull/957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #957: Update comfy-table to 5.0
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #957:
URL: https://github.com/apache/arrow-rs/pull/957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #957: Update comfy-table to 5.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #957:
URL: https://github.com/apache/arrow-rs/pull/957#issuecomment-972965422
Once this is merged into master I'll backport it into `active_release` (for inclusion in arrow-rs 6.3.0) and verify it doesn't break `DataFusion`
Thanks @carols10cents !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org