You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Stephen O'Donnell (Jira)" <ji...@apache.org> on 2026/09/08 19:26:00 UTC

[jira] [Resolved] (HDDS-16385) Minor cleanups in NodeDecommissionManager

     [ https://issues.apache.org/jira/browse/HDDS-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen O'Donnell resolved HDDS-16385.
--------------------------------------
    Fix Version/s: 2.3.0
       Resolution: Fixed

> Minor cleanups in NodeDecommissionManager
> -----------------------------------------
>
>                 Key: HDDS-16385
>                 URL: https://issues.apache.org/jira/browse/HDDS-16385
>             Project: Apache Ozone
>          Issue Type: Task
>          Components: SCM
>            Reporter: Navin Kumar
>            Assignee: Navin Kumar
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.3.0
>
>
> # In {{{}NodeDecommissionManager.parseHostname(){}}}, the {{InvalidHostStringException}} message has a typo — {{"does not contain a value hostname or hostname:port definition"}} should read {{{}"a valid hostname"{}}}.
>  # In {{{}NodeDecommissionManager.checkIfMaintenancePossible(){}}}, the list copy is redundant — {{List<DatanodeDetails> validDns = dns.stream().collect(Collectors.toList());}} 
> Followed by {{Collections.copy(validDns, dns);}} Which copies {{dns}} twice, and should be simplified to {{List<DatanodeDetails> validDns = new ArrayList<>(dns);}} 
> Which is matching with other implementations like {{checkIfDecommissionPossible() definition.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org