You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org> on 2007/11/14 12:32:25 UTC
[jira] Created: (MECLIPSE-344) connecting existing workspace
artifact-projects
connecting existing workspace artifact-projects
-----------------------------------------------
Key: MECLIPSE-344
URL: http://jira.codehaus.org/browse/MECLIPSE-344
Project: Maven 2.x Eclipse Plugin
Issue Type: New Feature
Components: dependency resolution
Reporter: Richard van Nieuwenhoven
Attachments: workspace-new-files.tgz, workspace.patch
This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
the property can be set with -DworkspaceToConnect=.....
I did not have the time to create Test cases but, i maybe someone can help with that!
The patch is based on the MECLIPSE-333 branch.
as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier reopened MECLIPSE-344:
--------------------------------------
We have a failure if the worspace doesn't exist and it could be a good idea to add a flag to activate this new feature only if asked (set to false by default).
http://www.nabble.com/maven-eclipse-plugin-2.5-coming-soon-td15207954s177.html
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113804 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
typo the property is -Declipse.workspaceToConnect=...
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: workspace-new-files.tgz, workspace.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126656 ]
Arnaud Heritier commented on MECLIPSE-344:
------------------------------------------
This last issue is reported in MECLIPSE-397 but I'm not surethat it is related to this one. You didn't have this problem with 2.4 ?
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Core : Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier closed MECLIPSE-344.
------------------------------------
Resolution: Fixed
This issue is fixed. Thanks for all patches submitted by Richard.
To try the latest SNAPSHOT (2.5-20080131.135640-18) of the incoming version you have to define and activate this profile :
{code}
<profile>
<id>apache.snapshots</id>
<repositories>
<repository>
<releases>
<enabled>false</enabled>
</releases>
<snapshots/>
<id>apache.snapshots</id>
<name>Maven Snapshots</name>
<url>http://people.apache.org/maven-snapshot-repository</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<releases>
<enabled>false</enabled>
</releases>
<snapshots/>
<id>apache.plugin.snapshots</id>
<name>Maven Plugin Snapshots</name>
<url>http://people.apache.org/maven-snapshot-repository</url>
</pluginRepository>
</pluginRepositories>
</profile>
{code}
Then you have to call this command :
{code}
mvn org.apache.maven.plugins:maven-eclipse-plugin:2.5-SNAPSHOT:eclipse
{code}
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Martin Zeltner (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116338 ]
Martin Zeltner commented on MECLIPSE-344:
-----------------------------------------
After the discussion with Richie I'm convinced now that the MECLIPSE-344 covers my needs (MECLIPSE-334) too. But dealing with files in the workspace folder looks to me a bit dangerous because they seem to be not so stable in their format as the .project and .classpath. Can anyone give me a link to documentation that convince me that the amount and the formats of these files are stable?
Cheers,
Martin
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Benjamin Baril (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_117613 ]
Benjamin Baril commented on MECLIPSE-344:
-----------------------------------------
Ahh, ok, I misunderstood the comment.
Building now
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126700 ]
Barrie Treloar commented on MECLIPSE-344:
-----------------------------------------
Not having an option as per http://jira.codehaus.org/browse/MECLIPSE-344#action_126688 makes sense to me.
If you have imported the project already into eclipse then link to it, otherwise use m2 repository.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Core : Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114677 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
these two include the complete patch on the today trunk R597676
- MECLIPSE-344.patch
- MECLIPSE-344.tgz
the others are old and included.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MECLIPSE-344:
-------------------------------------
Affects Version/s: 2.4
Fix Version/s: 2.5
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard van Nieuwenhoven updated MECLIPSE-344:
----------------------------------------------
Attachment: MECLIPSE-344.tgz
MECLIPSE-344.patch
updated the patch to include test cases for the workspace code!
included is now:
- connect to artefact's available in the workspace as projects
- use the correct default class path container depending on the compiler
- exclude artefact's from using project references (by removing them from the workspace)
I did not have the time to refactor the workspace reader stuff... Creating tests took a lot of time..
But i think we should split the workspace configuration class in a class not eclipse specific and an eclipse specific subclass.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126688 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
Only linking the SNAPSHOT's, can be done, the problem is the list of options are getting more and more complex and interweaving.
So i think it is best to make no new option but let the user decide with the eclipse means available (what's in the workspace will be linked).
I think the best solution is to import or delete (just from the workspace) the projects as needed and then let the eclipse plugin connect them.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Core : Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard van Nieuwenhoven updated MECLIPSE-344:
----------------------------------------------
Attachment: MECLIPSE-344+rad7.tgz
MECLIPSE-344+rad7.patch
Updated the patch for the current snapshot and included the standard JRE resolution of eclipse.
The workspace scanning is now re factored to reader and data class.
Now also included is the RAD-7 support (that needs the workspace reading) with tests.
- MECLIPSE-344+rad7.patch contains the patch and all new text files
- MECLIPSE-344+rad7.tgz contains the new binary files
to use the RAD-7 support the option
- workspaceToConnect must point to the current workspace directory (use ${workspace_loc} in eclipse launches)
- wtpdefaultserver contains the exact name or a substring of the defined wtp server to use
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Joerg Schaible (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122018 ]
Joerg Schaible commented on MECLIPSE-344:
-----------------------------------------
Will it link always all projects or is it possible to link only the SNAPSHOTs? The difference is, that with the information from the Eclipse workspace you don't have to rebuild all Eclipse files at once to get the SNAPSHOTs linked. You will have the information now to rebuild the Eclipse projects for a single submodule only, but have the SNAPSHOTs still linked. Therefore it would be really nice to have both operation modes.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114611 ]
Arnaud Heritier commented on MECLIPSE-344:
------------------------------------------
One question about your patch : Why did you call the configuration variable for the workspace : workspaceToConnect
I believed there was already a workspace var but it's not the case.
The workspace is in the new Mojo for workspace configuration.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116352 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
this part of file format did not change since 2.0 and that's a long time. It is also protected by a magic code so no version incompatibility possible.
And we will now use a dependency to the original eclipse (binaries) to read them, so i think we are on the save side here ;-)
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard van Nieuwenhoven updated MECLIPSE-344:
----------------------------------------------
Attachment: workspace_with_limit.patch
There are a few jira's about exluding some projects from using project references. Now this is rather easy done if the workspace is known.
I extended the patch to include the option:
-Declipse.limitProjectReferencesToWorkspace=true
This option will force projects that are not in the workspace but in the reactor to be used as jars.
this patch includes the original patch!
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "David J. M. Karlsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119515 ]
David J. M. Karlsen commented on MECLIPSE-344:
----------------------------------------------
This issue is related to: http://jira.codehaus.org/browse/MECLIPSE-341
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_117608 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
it contains the binary files for the patch! "svn diff" can not handle binary files.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115894 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
a small fix for my patch that will give the class path container lookup partly back to eclipse.
---------ReadWorkspaceLocations---------------
//add constant
private static final String CLASSPATHENTRY_STANDARD = CLASSPATHENTRY_DEFAULT+"/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/";
---------ReadWorkspaceLocations---------------
//change the method to add defaults known by eclipse
public static HashMap readAvailableJREs( String workspaceLocation, Log logger )
{
HashMap jreMap = new HashMap();
jreMap.put( "1.2", CLASSPATHENTRY_STANDARD+"J2SE-1.2" );
jreMap.put( "1.3", CLASSPATHENTRY_STANDARD+"J2SE-1.3" );
jreMap.put( "1.4", CLASSPATHENTRY_STANDARD+"J2SE-1.4" );
jreMap.put( "1.5", CLASSPATHENTRY_STANDARD+"J2SE-1.5" );
jreMap.put( "5", jreMap.get("1.5") );
jreMap.put( "1.6", CLASSPATHENTRY_STANDARD+"JavaSE-1.6" );
jreMap.put( "6", jreMap.get("1.6") );
---------EclipsePluginTest---------------
// changed test result in testProject38and39()
doTestProject38and39( "project-38", workspace15, "J2SE-1.3" ,null);
-----------------------------------------
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MECLIPSE-344 started by Arnaud Heritier.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114636 ]
Richard van Nieuwenhoven commented on MECLIPSE-344:
---------------------------------------------------
a good question! the problem is that the eclipse.workspace variable is used for something different.
And i didn't want to break the old behavior!
Could you check if it it is still needed? maybe even deprecate it?
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: dependency resolution
> Reporter: Richard van Nieuwenhoven
> Attachments: workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Pedro (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123231 ]
Pedro commented on MECLIPSE-344:
--------------------------------
I just noticed a small problem with this fix.
If you have a dependency on a project for source code and tests, the project is
added twice to the "Required projects in the build path".
This of course causes eclipse to complain that the project has been added twice.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>outboundInterfaces</artifactId>
<classifier>${environment.type}</classifier>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>outboundInterfaces</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier closed MECLIPSE-344.
------------------------------------
Resolution: Fixed
I think we solved all problems discussed on the mailing list. I close the issue. Please open new ones if necessary
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Core : Dependencies resolution and build path
> Affects Versions: 2.4
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Fix For: 2.5
>
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-344) connecting existing workspace
artifact-projects
Posted by "Benjamin Baril (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_117602 ]
Benjamin Baril commented on MECLIPSE-344:
-----------------------------------------
MECLIPSE-344+rad7.tgz is 1kb and does not contain the binary as stated in the above comment.
> connecting existing workspace artifact-projects
> -----------------------------------------------
>
> Key: MECLIPSE-344
> URL: http://jira.codehaus.org/browse/MECLIPSE-344
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Components: Dependencies resolution and build path
> Reporter: Richard van Nieuwenhoven
> Assignee: Arnaud Heritier
> Attachments: MECLIPSE-344+rad7.patch, MECLIPSE-344+rad7.tgz, MECLIPSE-344.patch, MECLIPSE-344.tgz, workspace-new-files.tgz, workspace.patch, workspace_with_limit.patch
>
>
> This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.
> the property can be set with -DworkspaceToConnect=.....
> I did not have the time to create Test cases but, i maybe someone can help with that!
> The patch is based on the MECLIPSE-333 branch.
> as usual the new files are in the extra tgz.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira