You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/03/17 21:35:24 UTC
[GitHub] [arrow] kou opened a new pull request, #34624: GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
kou opened a new pull request, #34624:
URL: https://github.com/apache/arrow/pull/34624
### Rationale for this change
Because it reports "object backing the pointer will be destroyed at the end of the full-expression" [-Wdangling-gsl] warning.
### What changes are included in this PR?
Create a variable for temporary `std::string`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34624: GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34624:
URL: https://github.com/apache/arrow/pull/34624#issuecomment-1474698871
Benchmark runs are scheduled for baseline = 4b20e70ad0513e22d05205342eafc1baedffbf71 and contender = 5b4595f966706c44fdd7a684b86de28d8d3cb49e. 5b4595f966706c44fdd7a684b86de28d8d3cb49e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f94460570f4e4f77aa774d0827ea4d3f...b1f7081ea02d4af7b0dfeeff44719640/)
[Failed :arrow_down:0.33% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b1c8d540e1de44fba7fe20f03743c5c8...5556806f54624e478da4ac276a798a5e/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a480b8b5462e4ae4ab853319c9bd351a...b085b0125d134a2a88483f6ef9b637c5/)
[Finished :arrow_down:0.06% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dd65bca52ea44761b5c55fbf4993086d...8f522a565e394819bcabee786ccf57e1/)
Buildkite builds:
[Finished] [`5b4595f9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2539)
[Finished] [`5b4595f9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2569)
[Finished] [`5b4595f9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2537)
[Finished] [`5b4595f9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2560)
[Finished] [`4b20e70a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2538)
[Failed] [`4b20e70a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2568)
[Finished] [`4b20e70a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2536)
[Finished] [`4b20e70a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2559)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34624: GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34624:
URL: https://github.com/apache/arrow/pull/34624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34624: GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34624:
URL: https://github.com/apache/arrow/pull/34624#issuecomment-1474424637
:warning: GitHub issue #34621 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34624: GH-34621: [GLib] Don't use "g_strdup(XXX->ToString().c_str())"
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34624:
URL: https://github.com/apache/arrow/pull/34624#issuecomment-1474424611
* Closes: #34621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org