You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/02 23:55:06 UTC

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18588


Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
4 files changed, 15 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#4).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 24 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8199/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 06:32:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#8).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 22 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

Had unrelated transient failures, re-running.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 01:58:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10698/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 16:49:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#9).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10706/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 22:11:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8188/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 16:43:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8197/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 19:59:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8181/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 03:58:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> Build Failed 
> 
> https://jenkins.impala.io/job/gerrit-code-review-checks/10692/ : Initial code review checks failed. See linked job for details on the failure.

retest


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 01:21:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8188/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 21:17:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10724/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 19:55:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

> Patch Set 12:
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8199/

Ran into 2 different transients on the 2 runs, but I also overlooked a real issue where something is looking for the new impala_shell dimension where it's not configured.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 19:03:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8181/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 01:22:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8190/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 21:50:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#12).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10715/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 20:29:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py@355
PS11, Line 355:     os.path.join(IMPALA_HOME, 'shell/build/py3/bin/impala-shell')
Adding so many dimensions makes these tests take awhile, ~20 minutes on my system for tests/shell.



-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 22:50:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#11).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 11:

(1 comment)

> Patch Set 11:
> 
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py@355
PS11, Line 355:     os.path.join(IMPALA_HOME, 'shell/build/py3/bin/impala-shell')
> Two tools at our disposal:
Without constraints, we run 7 variants:
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: dev | strict_hs2_protocol: False | protocol: beeswax | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python2 | strict_hs2_protocol: True | protocol: hs2 | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python3 | strict_hs2_protocol: True | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python3 | strict_hs2_protocol: False | protocol: hs2 | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python2 | strict_hs2_protocol: False | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: dev | strict_hs2_protocol: True | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: dev | strict_hs2_protocol: True | protocol: hs2 | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED

Naively I would have expected 15: (beeswax, hs2, hs2 strict, hs2-http, hs2-http strict) x (dev, python2, python3).

With constraints, its 6 variants:
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: dev | strict_hs2_protocol: False | protocol: beeswax | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python2 | strict_hs2_protocol: False | protocol: hs2 | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python3 | strict_hs2_protocol: False | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python3 | strict_hs2_protocol: False | protocol: hs2 | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: python2 | strict_hs2_protocol: False | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED
tests/shell/test_shell_interactive.py::TestImpalaShellInteractive::test_welcome_string[impala_shell: dev | strict_hs2_protocol: True | protocol: hs2-http | exec_option: {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 5000, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED

Seems dimensions are already being restricted somewhat, and it's not clear to me adding constraints is helping. We end up never running hs2-http+strict.



-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 18:44:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12: Code-Review+1

This is looking good to me. As long as tests pass, I'm ready to +2 this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 23:21:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8184/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 20:47:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#7).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10703/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 17:56:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Reviewed-on: http://gerrit.cloudera.org:8080/18588
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 9 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 14: Verified+1

The top of the stack passes tests


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 16:41:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8199/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 01:59:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10705/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 21:45:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8187/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 22:57:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10708/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 16:42:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10711/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 18:02:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#3).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
6 files changed, 23 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10739/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 22:42:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 12: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8197/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 00:30:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10717/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 22:37:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 14: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 16:33:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10692/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 00:05:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#5).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 22 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8184/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 16:35:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10700/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 17:11:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#6).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 venv, installs impala-shell into it, and runs tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8187/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Jun 2022 03:27:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8190/


-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 02:19:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py@355
PS11, Line 355:     os.path.join(IMPALA_HOME, 'shell/build/py3/bin/impala-shell')
> Adding so many dimensions makes these tests take awhile, ~20 minutes on my 
Two tools at our disposal:
1. We can add constraints and drop specific test configurations that might be redundant.
2. We can move some test configurations to the "exhaustive" tests.
Both are limiting what we would find via the usual precommit.

Our dimensions are:
3 protocols (beeswax, hs2, hs2-http)
3 shells (non-pypi, pypi py2, pypi py3)
strict_hs2_protocol=True,False

For core, we could restrict strict_hs2_protocol=True to the non-pypi shell. Beeswax is deprecated, and we could restrict it to the non-pypi + pypi py3.

For exhaustive, we could run everything.

Here's an example of a test case that adds constraints for core:
https://github.com/apache/impala/blob/master/tests/query_test/test_join_queries.py#L61-L63



-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 00:50:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#10).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8373: Test impala-shell with python3

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18588

to look at the new patch set (#13).

Change subject: IMPALA-8373: Test impala-shell with python3
......................................................................

IMPALA-8373: Test impala-shell with python3

Sets up a python3 virtualenv, installs impala-shell into it, and runs
tests.

Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
---
M CMakeLists.txt
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/CMakeLists.txt
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/18588/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56
Gerrit-Change-Number: 18588
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>