You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/09/25 06:08:35 UTC
[GitHub] [activemq-artemis] andytaylor opened a new pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
andytaylor opened a new pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278
https://issues.apache.org/jira/browse/ARTEMIS-2908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494780961
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -155,5 +157,38 @@ public static Double readNullableDouble(ActiveMQBuffer buffer) {
}
}
+ public static int sizeOfNullableString(String s) {
+ if (s == null) {
+ return DataConstants.SIZE_BOOLEAN;
+ }
+ return DataConstants.SIZE_BOOLEAN + sizeOfString(s);
+ }
+
+ public static int sizeOfeString(String s) {
Review comment:
This one doesn't look used (nor correct)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
andytaylor commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494864910
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -16,8 +16,10 @@
*/
package org.apache.activemq.artemis.utils;
+import io.netty.buffer.ByteBufUtil;
import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494774165
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -16,8 +16,10 @@
*/
package org.apache.activemq.artemis.utils;
+import io.netty.buffer.ByteBufUtil;
import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
Review comment:
This import doesn't look used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494774165
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -16,8 +16,10 @@
*/
package org.apache.activemq.artemis.utils;
+import io.netty.buffer.ByteBufUtil;
import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
Review comment:
This import doesn't look used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494780961
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -155,5 +157,38 @@ public static Double readNullableDouble(ActiveMQBuffer buffer) {
}
}
+ public static int sizeOfNullableString(String s) {
+ if (s == null) {
+ return DataConstants.SIZE_BOOLEAN;
+ }
+ return DataConstants.SIZE_BOOLEAN + sizeOfString(s);
+ }
+
+ public static int sizeOfeString(String s) {
Review comment:
This one doesn't look correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
andytaylor commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494864910
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -16,8 +16,10 @@
*/
package org.apache.activemq.artemis.utils;
+import io.netty.buffer.ByteBufUtil;
import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3278: ARTEMIS-2908 - Persist Divert Configuration in Bindings journal
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3278:
URL: https://github.com/apache/activemq-artemis/pull/3278#discussion_r494780961
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -155,5 +157,38 @@ public static Double readNullableDouble(ActiveMQBuffer buffer) {
}
}
+ public static int sizeOfNullableString(String s) {
+ if (s == null) {
+ return DataConstants.SIZE_BOOLEAN;
+ }
+ return DataConstants.SIZE_BOOLEAN + sizeOfString(s);
+ }
+
+ public static int sizeOfeString(String s) {
Review comment:
This one doesn't look correct
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/BufferHelper.java
##########
@@ -155,5 +157,38 @@ public static Double readNullableDouble(ActiveMQBuffer buffer) {
}
}
+ public static int sizeOfNullableString(String s) {
+ if (s == null) {
+ return DataConstants.SIZE_BOOLEAN;
+ }
+ return DataConstants.SIZE_BOOLEAN + sizeOfString(s);
+ }
+
+ public static int sizeOfeString(String s) {
Review comment:
This one doesn't look used (nor correct)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org