You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "rfellows (via GitHub)" <gi...@apache.org> on 2025/01/27 19:20:23 UTC
[PR] [NIFI-14185] - upgrade angular 19, nx 20 [nifi]
rfellows opened a new pull request, #9669:
URL: https://github.com/apache/nifi/pull/9669
# Summary
[NIFI-14185](https://issues.apache.org/jira/browse/NIFI-14185)
Migrated to Nx latest (20). This also upgraded to Angular 19. This PR is everything required for those changes to be complete.
In angular 19, the default component type is standalone. So if you do not declare it `standalone: false`, it will be true. This change had ramifications including needing to upgrade some 3rd party components to make them compatible as well as relaxing an eslint rule from error to warn when declaring a component as `standalone: false`.
There were a couple of new compiler errors that showed up as a result of the upgrade too. These were solved in this PR as well.
One particular change to mention, the mat-expand-panel had some behavior changes that made scrolling the contents of the documentation panel on load not work properly. You will see in this PR that we now initialize state of the desired expanded panel based on the current route and control its expanded state through properties on the class rather than assume the `openAll` method on the accordion will complete in time before the attempt to scroll happens.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14185] - upgrade angular 19, nx 20 [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan merged PR #9669:
URL: https://github.com/apache/nifi/pull/9669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14185] - upgrade angular 19, nx 20 [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #9669:
URL: https://github.com/apache/nifi/pull/9669#discussion_r1937446948
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/documentation/feature/documentation.component.ts:
##########
@@ -38,7 +38,7 @@ import {
import { ComponentType, isDefinedAndNotNull, NiFiCommon, selectCurrentRoute } from '@nifi/shared';
import { MatAccordion } from '@angular/material/expansion';
import { FormBuilder, FormControl, FormGroup } from '@angular/forms';
-import { debounceTime, distinctUntilChanged, map } from 'rxjs';
+import {combineLatestWith, debounceTime, distinctUntilChanged, map} from 'rxjs';
Review Comment:
Looks like you need to run prettier here.
##########
nifi-frontend/src/main/frontend/.eslintrc.json:
##########
@@ -26,7 +26,8 @@
{
"suffixes": [""]
}
- ]
+ ],
+ "@angular-eslint/prefer-standalone": "warn"
Review Comment:
Do we want to just turn this rule off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14185] - upgrade angular 19, nx 20 [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows commented on code in PR #9669:
URL: https://github.com/apache/nifi/pull/9669#discussion_r1937456583
##########
nifi-frontend/src/main/frontend/.eslintrc.json:
##########
@@ -26,7 +26,8 @@
{
"suffixes": [""]
}
- ]
+ ],
+ "@angular-eslint/prefer-standalone": "warn"
Review Comment:
I considered turning it off but decided to make it a warning as it is something we should strive to resolve going forward. We should make all components standalone, these warning remind us of which ones still need converted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org