You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/30 16:30:17 UTC
[GitHub] [arrow] 0x26res opened a new pull request, #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
0x26res opened a new pull request, #13757:
URL: https://github.com/apache/arrow/pull/13757
https://issues.apache.org/jira/browse/ARROW-17256
Not 100% sure it should be fixed at this level. Should `combine_chunks` receive a `DataType` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13757:
URL: https://github.com/apache/arrow/pull/13757#issuecomment-1200247666
https://issues.apache.org/jira/browse/ARROW-17256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13757:
URL: https://github.com/apache/arrow/pull/13757#issuecomment-1208793147
Benchmark runs are scheduled for baseline = d171b6c35481ccfffe398a288c2c2f8a9ee1123c and contender = 210cf061390e96c032008a41dd01c683b4b8e6e3. 210cf061390e96c032008a41dd01c683b4b8e6e3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b261272178124722b93262f4123bf17f...5f13954ab5b04f519bff6ee4664f2180/)
[Failed :arrow_down:0.2% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbd7a2ea470245de9a8213c4e2b64539...d1d0e604f2b447f080c8442d097c056f/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ce269dbf70e48cb8153b3563ed840d7...b3e681e122ed4f22b2ed5e3418650373/)
[Finished :arrow_down:0.18% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ec58c47e43634e3ead1c2f3c3f3b367a...aed8ef1327d249329abb68015ca1aa56/)
Buildkite builds:
[Finished] [`210cf061` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1274)
[Failed] [`210cf061` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1286)
[Finished] [`210cf061` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1269)
[Finished] [`210cf061` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1288)
[Finished] [`d171b6c3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1273)
[Finished] [`d171b6c3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1285)
[Finished] [`d171b6c3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1268)
[Finished] [`d171b6c3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1287)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13757:
URL: https://github.com/apache/arrow/pull/13757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13757:
URL: https://github.com/apache/arrow/pull/13757#discussion_r940382803
##########
python/pyarrow/tests/test_array.py:
##########
@@ -3192,3 +3192,13 @@ def test_to_pandas_timezone():
arr = pa.chunked_array([arr])
s = arr.to_pandas()
assert s.dt.tz is not None
+
+
+def test_chunked_array_can_combine_chunks_with_no_chunks():
Review Comment:
`combine_chunks` is tested in `test_table.py`, could you move your test there too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13757:
URL: https://github.com/apache/arrow/pull/13757#discussion_r940538654
##########
python/pyarrow/tests/test_table.py:
##########
@@ -117,6 +117,15 @@ def test_combine_chunks():
expected = pa.array([1, 2, 1, 2])
assert res.equals(expected)
+def test_chunked_array_can_combine_chunks_with_no_chunks():
Review Comment:
Add newline to fix Python lint.
```suggestion
def test_chunked_array_can_combine_chunks_with_no_chunks():
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13757:
URL: https://github.com/apache/arrow/pull/13757#issuecomment-1201192049
IMO: yes, combine_chunks (which boils down to Concatenate in C++) should just take a datatype, though that would be a larger change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13757: ARROW-17256 [Python] Can't call combine_chunks on empty ChunkedArray
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13757:
URL: https://github.com/apache/arrow/pull/13757#issuecomment-1200247670
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org