You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2007/09/25 14:11:59 UTC
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Anyone object if I commit this patch? The Exception messages still need
to be fixed.
-Mark.
On 25 September 2007 at 4:57, "Mark Hindess (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HARMONY-4810?page=com.atlassian.
> jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Mark Hindess updated HARMONY-4810:
> ----------------------------------
>
> Attachment: bcprov.dummy.IDEAEngine.diff
>
> The patch doesn't contain the binary IDEAEngine.class. It is easy to create m
> anually but complicated to do at build time so I will be checking it in.
>
>
> > Remove IDEA from bcprov.jar
> > ---------------------------
> >
> > Key: HARMONY-4810
> > URL: https://issues.apache.org/jira/browse/HARMONY-4810
> > Project: Harmony
> > Issue Type: Task
> > Components: Classlib
> > Reporter: Mark Hindess
> > Assignee: Mark Hindess
> > Attachments: bcprov.dummy.IDEAEngine.diff, bcprov.noidea.diff
> >
> >
> > Remove patent encumbered algortihms from the bcprov.jar we distribute. See
> :
> > http://mail-archives.apache.org/mod_mbox/harmony-dev/200709.mbox/%3c46EFA
> 342.7050801@gmail.com%3e
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Tim Ellison <t....@gmail.com>.
Alexey Varlamov wrote:
> How about adding the link to idea_algorithm page to sitemap?
I don't think so. It's not a page we want people to browse to, it's a
type of 'error page'.
Regards,
Tim
> 2007/9/26, Tim Ellison <t....@gmail.com>:
>> Mark Hindess wrote:
>>> On 25 September 2007 at 18:27, Tim Ellison <t....@gmail.com> wrote:
>>>> Mark Hindess wrote:
>>>>> Anyone object if I commit this patch? The Exception messages still need
>>>>> to be fixed.
>>>> Did you want to keep the name bcprov.jar in the runtime, or keep the
>>>> .noidea. version so people can see it has been modified?
>>> I meant to keep the name bcprov.jar in the runtime but obviously we
>>> can easily change it if you'd prefer. I figured it would be easier
>>> to replace if it was just a question of overwriting it and avoid
>>> people accidentally ending up with both the dummy and the real one in
>>> jre/lib/ext at the same time. But I don't feel particularly strongly
>>> about it.
>> I don't feel strongly about it either, just checking it wasn't an oversight.
>>
>> Regards,
>> Tim
>>
>>
>
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Alexey Varlamov <al...@gmail.com>.
How about adding the link to idea_algorithm page to sitemap?
2007/9/26, Tim Ellison <t....@gmail.com>:
> Mark Hindess wrote:
> > On 25 September 2007 at 18:27, Tim Ellison <t....@gmail.com> wrote:
> >> Mark Hindess wrote:
> >>> Anyone object if I commit this patch? The Exception messages still need
> >>> to be fixed.
> >> Did you want to keep the name bcprov.jar in the runtime, or keep the
> >> .noidea. version so people can see it has been modified?
> >
> > I meant to keep the name bcprov.jar in the runtime but obviously we
> > can easily change it if you'd prefer. I figured it would be easier
> > to replace if it was just a question of overwriting it and avoid
> > people accidentally ending up with both the dummy and the real one in
> > jre/lib/ext at the same time. But I don't feel particularly strongly
> > about it.
>
> I don't feel strongly about it either, just checking it wasn't an oversight.
>
> Regards,
> Tim
>
>
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Tim Ellison <t....@gmail.com>.
Mark Hindess wrote:
> On 25 September 2007 at 18:27, Tim Ellison <t....@gmail.com> wrote:
>> Mark Hindess wrote:
>>> Anyone object if I commit this patch? The Exception messages still need
>>> to be fixed.
>> Did you want to keep the name bcprov.jar in the runtime, or keep the
>> .noidea. version so people can see it has been modified?
>
> I meant to keep the name bcprov.jar in the runtime but obviously we
> can easily change it if you'd prefer. I figured it would be easier
> to replace if it was just a question of overwriting it and avoid
> people accidentally ending up with both the dummy and the real one in
> jre/lib/ext at the same time. But I don't feel particularly strongly
> about it.
I don't feel strongly about it either, just checking it wasn't an oversight.
Regards,
Tim
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Mark Hindess <ma...@googlemail.com>.
On 25 September 2007 at 18:27, Tim Ellison <t....@gmail.com> wrote:
> Mark Hindess wrote:
> > Anyone object if I commit this patch? The Exception messages still need
> > to be fixed.
>
> Did you want to keep the name bcprov.jar in the runtime, or keep the
> .noidea. version so people can see it has been modified?
I meant to keep the name bcprov.jar in the runtime but obviously we
can easily change it if you'd prefer. I figured it would be easier
to replace if it was just a question of overwriting it and avoid
people accidentally ending up with both the dummy and the real one in
jre/lib/ext at the same time. But I don't feel particularly strongly
about it.
Regards,
Mark.
> Index: make/build-java.xml
> ===================================================================
> --- make/build-java.xml (revision 579314)
> +++ make/build-java.xml (working copy)
> @@ -227,7 +227,7 @@
> </copy>
>
> <!-- Copy across the extension dependency jars -->
> - <copy tofile="${hy.jdk}/jre/lib/ext/bcprov.jar" verbose="true"
> + <copy tofile="${hy.jdk}/jre/lib/ext/bcprov.noidea.jar"
> verbose="true"
> flatten="yes" overwrite="true">
> <fileset file="${bcprov.jar}" />
> </copy>
>
>
> Regards,
> Tim
>
>
>
> > On 25 September 2007 at 4:57, "Mark Hindess (JIRA)" <ji...@apache.org> wrote
> :
> >> [ https://issues.apache.org/jira/browse/HARMONY-4810?page=com.atlassi
> an.
> >> jira.plugin.system.issuetabpanels:all-tabpanel ]
> >>
> >> Mark Hindess updated HARMONY-4810:
> >> ----------------------------------
> >>
> >> Attachment: bcprov.dummy.IDEAEngine.diff
> >>
> >> The patch doesn't contain the binary IDEAEngine.class. It is easy to creat
> e m
> >> anually but complicated to do at build time so I will be checking it in.
> >>
> >>
> >>> Remove IDEA from bcprov.jar
> >>> ---------------------------
> >>>
> >>> Key: HARMONY-4810
> >>> URL: https://issues.apache.org/jira/browse/HARMONY-4810
> >>> Project: Harmony
> >>> Issue Type: Task
> >>> Components: Classlib
> >>> Reporter: Mark Hindess
> >>> Assignee: Mark Hindess
> >>> Attachments: bcprov.dummy.IDEAEngine.diff, bcprov.noidea.diff
> >>>
> >>>
> >>> Remove patent encumbered algortihms from the bcprov.jar we distribute. S
> ee
> >> :
> >>> http://mail-archives.apache.org/mod_mbox/harmony-dev/200709.mbox/%3c46E
> FA
> >> 342.7050801@gmail.com%3e
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >
> >
> >
>
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Tim Ellison <t....@gmail.com>.
Mark Hindess wrote:
> Anyone object if I commit this patch? The Exception messages still need
> to be fixed.
Did you want to keep the name bcprov.jar in the runtime, or keep the
.noidea. version so people can see it has been modified?
Index: make/build-java.xml
===================================================================
--- make/build-java.xml (revision 579314)
+++ make/build-java.xml (working copy)
@@ -227,7 +227,7 @@
</copy>
<!-- Copy across the extension dependency jars -->
- <copy tofile="${hy.jdk}/jre/lib/ext/bcprov.jar" verbose="true"
+ <copy tofile="${hy.jdk}/jre/lib/ext/bcprov.noidea.jar"
verbose="true"
flatten="yes" overwrite="true">
<fileset file="${bcprov.jar}" />
</copy>
Regards,
Tim
> On 25 September 2007 at 4:57, "Mark Hindess (JIRA)" <ji...@apache.org> wrote:
>> [ https://issues.apache.org/jira/browse/HARMONY-4810?page=com.atlassian.
>> jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Mark Hindess updated HARMONY-4810:
>> ----------------------------------
>>
>> Attachment: bcprov.dummy.IDEAEngine.diff
>>
>> The patch doesn't contain the binary IDEAEngine.class. It is easy to create m
>> anually but complicated to do at build time so I will be checking it in.
>>
>>
>>> Remove IDEA from bcprov.jar
>>> ---------------------------
>>>
>>> Key: HARMONY-4810
>>> URL: https://issues.apache.org/jira/browse/HARMONY-4810
>>> Project: Harmony
>>> Issue Type: Task
>>> Components: Classlib
>>> Reporter: Mark Hindess
>>> Assignee: Mark Hindess
>>> Attachments: bcprov.dummy.IDEAEngine.diff, bcprov.noidea.diff
>>>
>>>
>>> Remove patent encumbered algortihms from the bcprov.jar we distribute. See
>> :
>>> http://mail-archives.apache.org/mod_mbox/harmony-dev/200709.mbox/%3c46EFA
>> 342.7050801@gmail.com%3e
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
>
>
Re: [jira] Updated: (HARMONY-4810) Remove IDEA from bcprov.jar
Posted by Alexey Petrenko <al...@gmail.com>.
+1 for commit
2007/9/25, Mark Hindess <ma...@googlemail.com>:
>
> Anyone object if I commit this patch? The Exception messages still need
> to be fixed.
>
> -Mark.
>
> On 25 September 2007 at 4:57, "Mark Hindess (JIRA)" <ji...@apache.org> wrote:
> >
> > [ https://issues.apache.org/jira/browse/HARMONY-4810?page=com.atlassian.
> > jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Mark Hindess updated HARMONY-4810:
> > ----------------------------------
> >
> > Attachment: bcprov.dummy.IDEAEngine.diff
> >
> > The patch doesn't contain the binary IDEAEngine.class. It is easy to create m
> > anually but complicated to do at build time so I will be checking it in.
> >
> >
> > > Remove IDEA from bcprov.jar
> > > ---------------------------
> > >
> > > Key: HARMONY-4810
> > > URL: https://issues.apache.org/jira/browse/HARMONY-4810
> > > Project: Harmony
> > > Issue Type: Task
> > > Components: Classlib
> > > Reporter: Mark Hindess
> > > Assignee: Mark Hindess
> > > Attachments: bcprov.dummy.IDEAEngine.diff, bcprov.noidea.diff
> > >
> > >
> > > Remove patent encumbered algortihms from the bcprov.jar we distribute. See
> > :
> > > http://mail-archives.apache.org/mod_mbox/harmony-dev/200709.mbox/%3c46EFA
> > 342.7050801@gmail.com%3e
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
>
>
>