[kudu-CR] KUDU-1938 Add support for VARCHAR pt 1

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 )

Change subject: KUDU-1938 Add support for VARCHAR pt 1
......................................................................


Patch Set 30: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13760/30/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/13760/30/src/kudu/common/common.proto@98
PS30, Line 98:   // For char/varchar columns
Should remove 'char' here.


http://gerrit.cloudera.org:8080/#/c/13760/30/src/kudu/common/partial_row.cc
File src/kudu/common/partial_row.cc:

http://gerrit.cloudera.org:8080/#/c/13760/30/src/kudu/common/partial_row.cc@233
PS30, Line 233:       case STRING:
              :       default:
              :         CHECK(col.type_info()->type() == STRING);
Nit: might be clearer as:

  case STRING:
    ...
    break;
  default:
    LOG(FATAL) << "Unexpected type " << col.type_info()->type();
    break;



-- 
To view, visit http://gerrit.cloudera.org:8080/13760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54
Gerrit-Change-Number: 13760
Gerrit-PatchSet: 30
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:01:18 +0000
Gerrit-HasComments: Yes