You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/07 21:12:59 UTC

[GitHub] [pulsar] rivernate opened a new pull request #6911: Split KafkaConnectSource into an abstract and impl

rivernate opened a new pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911


   <!--
   ### Contribution Checklist
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   ### Motivation
   
   We do extra processing steps and send back a different Record type than what is provided by KafkaConnectSource, but still desire to reuse a majority of the code. Having an Abstract implementation allows us to reuse the majority of the code while still being able to customize the Record and processRecord method.
   
   ### Modifications
   
   KafkaConnectSource was split into AbstractKafkaConnectSource with KafkaConnectSource extending the abstract. The processRecord method was made public to allow overriding of the method. The inner class KafkaSourceRecord was also split into an abstract implementation to allow different types of Records.
   
   ### Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   The change should only be a splitting of code with no behavioral changes to the KafkaConnectSource class.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rivernate commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
rivernate commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-630416327


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-633843490


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rivernate commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
rivernate commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-632904273


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rivernate commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
rivernate commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-628206418


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rivernate commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
rivernate commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-628289560


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rivernate commented on pull request #6911: Split KafkaConnectSource into an abstract and impl

Posted by GitBox <gi...@apache.org>.
rivernate commented on pull request #6911:
URL: https://github.com/apache/pulsar/pull/6911#issuecomment-634251318


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org