You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/08 22:20:34 UTC
[GitHub] [lucenenet] NightOwl888 commented on a diff in pull request #753: Remove .NET5 from builds
NightOwl888 commented on code in PR #753:
URL: https://github.com/apache/lucenenet/pull/753#discussion_r1017141537
##########
Directory.Build.targets:
##########
@@ -39,7 +39,7 @@
</PropertyGroup>
<!-- Features in .NET Standard, .NET Core, .NET 5.x, and .NET 6.x only (no .NET Framework support) -->
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard')) Or $(TargetFramework.StartsWith('netcoreapp')) Or '$(TargetFramework)' == 'net5.0' Or '$(TargetFramework)' == 'net6.0' ">
+ <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard')) Or $(TargetFramework.StartsWith('netcoreapp')) Or '$(TargetFramework)' == 'net6.0' ">
Review Comment:
Please leave the legacy frameworks in this file so it can still be comprehended why these features exist. The idea is that we can change targets at any time and this file will correctly adjust the compilation to match the targets.
##########
Directory.Build.targets:
##########
@@ -49,8 +49,8 @@
<DebugType>portable</DebugType>
</PropertyGroup>
- <!-- Features in .NET Standard 2.1, .NET 5.x, and .NET 6.x only -->
- <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.1' Or $(TargetFramework.StartsWith('netcoreapp3.')) Or '$(TargetFramework)' == 'net5.0' Or '$(TargetFramework)' == 'net6.0' ">
+ <!-- Features in .NET Standard 2.1 and .NET 6.x only -->
Review Comment:
Please leave the legacy frameworks in this file so it can still be comprehended why these features exist.
##########
Directory.Build.targets:
##########
@@ -80,8 +80,8 @@
</PropertyGroup>
- <!-- Features in .NET Framework 4.5+, .NET Standard 2.x, .NET Core 2.x, .NET Core 3.x, .NET 5.x (No .NET 6.x support) -->
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or $(TargetFramework.StartsWith('netstandard2.')) Or $(TargetFramework.StartsWith('netcoreapp2.')) Or $(TargetFramework.StartsWith('netcoreapp3.')) Or '$(TargetFramework)' == 'net5.0' ">
+ <!-- Features in .NET Framework 4.5+, .NET Standard 2.x, (No .NET 6.x support) -->
Review Comment:
Please leave the legacy frameworks in this file so it can still be comprehended why these features exist.
##########
TestTargetFramework.props:
##########
@@ -28,13 +28,13 @@
this setting only affects the test projects. -->
<!--<TargetFramework>net461</TargetFramework>-->
<!--<TargetFramework>net48</TargetFramework>-->
- <TargetFramework>net5.0</TargetFramework>
+ <TargetFramework>net6.0</TargetFramework>
Review Comment:
Please revert.
##########
Directory.Build.targets:
##########
@@ -60,15 +60,15 @@
</PropertyGroup>
- <!-- Features in .NET Standard 2.x, .NET Core 2.x, .NET Core 3.x, .NET 5.x, and .NET 6.x -->
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard2.')) Or $(TargetFramework.StartsWith('netcoreapp2.')) Or $(TargetFramework.StartsWith('netcoreapp3.')) Or '$(TargetFramework)' == 'net5.0' Or '$(TargetFramework)' == 'net6.0' ">
+ <!-- Features in .NET Standard 2.x and .NET 6.x -->
Review Comment:
Please leave the legacy frameworks in this file so it can still be comprehended why these features exist.
##########
azure-pipelines.yml:
##########
@@ -378,66 +371,6 @@ stages:
maximumAllowedFailures: $(maximumAllowedFailures)
dotNetSdkVersion: '$(DotNetSDKVersion)'
- - job: Test_net5_0_x64
Review Comment:
Please revert.
##########
TestTargetFramework.props:
##########
@@ -28,13 +28,13 @@
this setting only affects the test projects. -->
<!--<TargetFramework>net461</TargetFramework>-->
<!--<TargetFramework>net48</TargetFramework>-->
- <TargetFramework>net5.0</TargetFramework>
+ <TargetFramework>net6.0</TargetFramework>
<!--<TargetFramework>net6.0</TargetFramework>-->
<!-- Allow the build script to pass in the test frameworks to build for.
This overrides the above TargetFramework setting.
LUCENENET TODO: Due to a parsing bug, we cannot pass a string with a ; to dotnet msbuild, so passing true as a workaround -->
- <TargetFrameworks Condition=" '$(TestFrameworks)' == 'true' ">net6.0;net5.0</TargetFrameworks>
+ <TargetFrameworks Condition=" '$(TestFrameworks)' == 'true' ">net6.0</TargetFrameworks>
Review Comment:
Please revert.
##########
Directory.Build.targets:
##########
@@ -60,15 +60,15 @@
</PropertyGroup>
- <!-- Features in .NET Standard 2.x, .NET Core 2.x, .NET Core 3.x, .NET 5.x, and .NET 6.x -->
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard2.')) Or $(TargetFramework.StartsWith('netcoreapp2.')) Or $(TargetFramework.StartsWith('netcoreapp3.')) Or '$(TargetFramework)' == 'net5.0' Or '$(TargetFramework)' == 'net6.0' ">
+ <!-- Features in .NET Standard 2.x and .NET 6.x -->
+ <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard2.')) Or '$(TargetFramework)' == 'net6.0' ">
<DefineConstants>$(DefineConstants);FEATURE_ICONFIGURATIONROOT_PROVIDERS</DefineConstants>
</PropertyGroup>
- <!-- Features in .NET Framework 4.5+, .NET Standard 2.x, .NET Core 2.x, .NET Core 3.x, .NET 5.x, and .NET 6.x -->
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or $(TargetFramework.StartsWith('netstandard2.')) Or $(TargetFramework.StartsWith('netcoreapp2.')) Or $(TargetFramework.StartsWith('netcoreapp3.')) Or '$(TargetFramework)' == 'net5.0' Or '$(TargetFramework)' == 'net6.0' ">
+ <!-- Features in .NET Framework 4.5+, .NET Standard 2.x, and .NET 6.x -->
Review Comment:
Please leave the legacy frameworks in this file so it can still be comprehended why these features exist.
##########
azure-pipelines.yml:
##########
@@ -378,66 +371,6 @@ stages:
maximumAllowedFailures: $(maximumAllowedFailures)
dotNetSdkVersion: '$(DotNetSDKVersion)'
- - job: Test_net5_0_x64
- condition: and(succeeded(), ne(variables['RunTests'], 'false'))
- strategy:
- matrix:
- Windows:
- osName: 'Windows'
- imageName: 'windows-2019'
- maximumParallelJobs: 8
- maximumAllowedFailures: 0 # Maximum allowed failures for a successful build
- Linux:
- osName: 'Linux'
- imageName: 'ubuntu-latest'
- maximumParallelJobs: 7
- maximumAllowedFailures: 0 # Maximum allowed failures for a successful build
- macOS:
- osName: 'macOS'
- imageName: 'macOS-latest'
- maximumParallelJobs: 7
- maximumAllowedFailures: 0 # Maximum allowed failures for a successful build
- displayName: 'Test net5.0,x64 on'
- pool:
- vmImage: $(imageName)
- steps:
- - template: '.build/azure-templates/run-tests-on-os.yml'
- parameters:
- osName: $(osName)
- framework: 'net5.0'
- vsTestPlatform: 'x64'
- testBinariesArtifactName: '$(TestBinariesArtifactName)'
- nugetArtifactName: '$(NuGetArtifactName)'
- testResultsArtifactName: '$(TestResultsArtifactName)'
- maximumParallelJobs: $(maximumParallelJobs)
- maximumAllowedFailures: $(maximumAllowedFailures)
- dotNetSdkVersion: '$(DotNetSDKVersion)'
-
- - job: Test_net5_0_x86 # Only run Nightly or if explicitly enabled with RunX86Tests
Review Comment:
Please revert.
##########
azure-pipelines.yml:
##########
@@ -236,13 +236,6 @@ stages:
binaryArtifactName: '$(BinaryArtifactName)'
testSettingsFilePath: '$(Build.ArtifactStagingDirectory)/$(TestSettingsFileName)'
- - template: '.build/azure-templates/publish-test-binaries.yml'
Review Comment:
Please revert.
##########
websites/apidocs/apiSpec/core/Lucene_Net_Codecs.md:
##########
@@ -186,7 +186,7 @@ Here is an example project file for .NET 5 for testing a project named `MyCodecs
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net5.0</TargetFramework>
+ <TargetFramework>net6.0</TargetFramework>
Review Comment:
This is fine, but please update line 183, otherwise the documentation is wrong.
```
Here is an example project file for .NET 6 for testing a project named `MyCodecs.csproj`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org