You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "rhoughton-pivot (GitHub)" <gi...@apache.org> on 2018/09/20 18:03:15 UTC
[GitHub] [geode] rhoughton-pivot opened pull request #2497:
GEODE-5600: Fix extension developer issues with buildinfo
As an extension developer, gradle's `rootProject` may not refer
to the Geode root project, depending on the extension's structure.
Co-authored-by: Robert Houghton <rh...@pivotal.io>
Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2497 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav closed pull request #2497: GEODE-5600: Fix
extension developer issues with buildinfo
Posted by "dickcav (GitHub)" <gi...@apache.org>.
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2497 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2497: GEODE-5600:
Fix extension developer issues with buildinfo
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Implicitly +1 as a co-author, but I'd love someone else to give an "official" checkmark.
[ Full content available at: https://github.com/apache/geode/pull/2497 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org