You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by traflm <gi...@git.apache.org> on 2018/02/05 13:28:19 UTC
[GitHub] trafodion pull request #1441: [TRAFODION-2908] create table with wrong char ...
GitHub user traflm opened a pull request:
https://github.com/apache/trafodion/pull/1441
[TRAFODION-2908] create table with wrong char length hang and crash
add a check if the key length is too long report error. Otherwise, SQL will go into a very long process to build the encoded key and finally failed. And in some cases crash, it makes little sense to check why it crash, so just add check and return error when key is too long.
HBase max rowkey len is 32K, so it is the hard limit for now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-2908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1441
----
commit 5f5808ab9d66bc2fba02292b3a0e5c371d3f5678
Author: Liu Ming <ov...@...>
Date: 2018-02-05T08:11:50Z
[TRAFODION-2908] create table with wrong char length hang and crash
----
---
[GitHub] trafodion pull request #1441: [TRAFODION-2908] create table with wrong char ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1441#discussion_r166065898
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -140,7 +140,7 @@
1138 ZZZZZ 99999 ADVANCED CRTCL DIALOUT --- unused ---
1139 ZZZZZ 99999 BEGINNER MAJOR DBADMIN System-generated column $0~ColumnName of base table $1~TableName cannot appear in the search condition of a check constraint definition.
1140 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Row-length $0~int0 exceeds the maximum allowed row-length of $1~int1 for table $2~TableName.
-1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN --- unused ---
+1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Key-length $0~int0 exceeds the maximum allowed rowkey length $1~int1.
--- End diff --
Also, would you please add the new message to the Messages Guide? Thanks.
---
[GitHub] trafodion pull request #1441: [TRAFODION-2908] create table with wrong char ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1441#discussion_r166065286
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -140,7 +140,7 @@
1138 ZZZZZ 99999 ADVANCED CRTCL DIALOUT --- unused ---
1139 ZZZZZ 99999 BEGINNER MAJOR DBADMIN System-generated column $0~ColumnName of base table $1~TableName cannot appear in the search condition of a check constraint definition.
1140 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Row-length $0~int0 exceeds the maximum allowed row-length of $1~int1 for table $2~TableName.
-1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN --- unused ---
+1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Key-length $0~int0 exceeds the maximum allowed rowkey length $1~int1.
--- End diff --
Consider rewording: "Key length $0-int0 exceeds the maximum allowed key length of $1~int1".
---
[GitHub] trafodion pull request #1441: [TRAFODION-2908] create table with wrong char ...
Posted by traflm <gi...@git.apache.org>.
Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1441#discussion_r166279557
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -140,7 +140,7 @@
1138 ZZZZZ 99999 ADVANCED CRTCL DIALOUT --- unused ---
1139 ZZZZZ 99999 BEGINNER MAJOR DBADMIN System-generated column $0~ColumnName of base table $1~TableName cannot appear in the search condition of a check constraint definition.
1140 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Row-length $0~int0 exceeds the maximum allowed row-length of $1~int1 for table $2~TableName.
-1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN --- unused ---
+1141 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Key-length $0~int0 exceeds the maximum allowed rowkey length $1~int1.
--- End diff --
Thanks Dave for the review, I will update teh Message Guide and modify the workding
---
[GitHub] trafodion pull request #1441: [TRAFODION-2908] create table with wrong char ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1441
---