[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1504: [HUDI-780] Add junit 5

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#discussion_r406563616
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
 ##########
 @@ -22,22 +22,22 @@
 import org.apache.hudi.config.HoodieWriteConfig;
 
 import com.codahale.metrics.Timer;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import java.util.Arrays;
 import java.util.Random;
 
 import static org.apache.hudi.metrics.Metrics.registerGauge;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 public class TestHoodieMetrics {
 
 Review comment:
   @yanghua @vinothchandar Some test classes do not have javadoc, while some others have. I think we'd better align on this just to standardize the codebase. If we agree that javadoc should be added to all test classes, then we'll fix them while making changes on those tests from now on. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services