Re: Review Request 71690: Added function to compute a common reservation ancestor.

[Benjamin Bannier <bb...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71690/#review218481
-----------------------------------------------------------



I think this patch does what we need. We want a function which when given two `Resources` (where all of each `Resources`' `Resource`s have identical `ReservationInfo`s, and where, but for the reservation state the two `Resources` are identical) will return the first `Resources` which can be reached by removing `ReservationInfo`s from the two `Resources`. This `Resources` always exists (bottom case: completely unreserved `Resources`).

One practical algorithm to find this `Resources` is to start with the bottom case, and push `reservations[0..]` onto it which are present in both the input resources.

- Benjamin Bannier


On Oct. 29, 2019, 7:14 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71690/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2019, 7:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9984
>     https://issues.apache.org/jira/browse/MESOS-9984
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new function `Resources::getReservationAncestor()` to compute
> a common reservation ancestor between two `Resources`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp b8aef28e08f85c87bb78f25a64b0d7318f2727cc 
>   src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24 
>   src/tests/resources_tests.cpp b5854656b7e9ce7af9e1d8ecad708066512d814f 
> 
> 
> Diff: https://reviews.apache.org/r/71690/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>