[GitHub] [jmeter] cse-peter-account edited a comment on pull request #673: Feature 65611

[GitBox <gi...@apache.org>]

cse-peter-account edited a comment on pull request #673:
URL: https://github.com/apache/jmeter/pull/673#issuecomment-933378894


   > What happens, when a user wants to use IPv6 and a port? Is it worth adding a complete library, to check for a IPv6 address, only?
   
   ************************************************************************************
   If a user wants to use an IPv6 port, it shouldn't be necessary to include a port, according to the following URL:
   
   https://docs.oracle.com/javase/8/docs/technotes/guides/net/ipv6_guide/#:~:text=IPv6%20in%20Java%20is%20transparent%20and%20automatic.%20Porting%20is%20not%20necessary
   
   "IPv6 in Java is transparent and automatic. Porting is not necessary;"
   ************************************************************************************
   I added a small, specialized library to check for IPv6, since that is what the library is specialized to do.  If we add manual code to check for IPv6 format, human errors could be introduced either now or later.
   
   Is it mandatory to remove the library before this feature is pushed to apache:master?
   ************************************************************************************
   
   Thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org