You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "Jimexist (via GitHub)" <gi...@apache.org> on 2023/04/17 08:13:32 UTC

[GitHub] [thrift] Jimexist commented on a diff in pull request #2787: THRIFT-5564: add GitHub action for python 2.x and 3.x

Jimexist commented on code in PR #2787:
URL: https://github.com/apache/thrift/pull/2787#discussion_r1168337093


##########
.github/workflows/build.yml:
##########
@@ -344,12 +344,79 @@ jobs:
       - name: Run make test_recursive for rust
         run: make -C lib/rs/test_recursive check
 
+  lib-python:
+    needs: compiler
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        python-version: ["2.x", "3.x"]

Review Comment:
   > I would drop Python v2. Python 2 has been sunsetted 1st of January 2020: https://www.python.org/doc/sunset-python-2/
   
   feel free to review https://github.com/apache/thrift/pull/2588 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org