You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Lukasz Gajowy (Jira)" <ji...@apache.org> on 2019/12/19 15:59:00 UTC
[jira] [Commented] (BEAM-7245) Encapsulate supplier, monitor and
metric naming logic in some common TestMetric type
[ https://issues.apache.org/jira/browse/BEAM-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000153#comment-17000153 ]
Lukasz Gajowy commented on BEAM-7245:
-------------------------------------
[~mwalenia] is this ticket finished?
> Encapsulate supplier, monitor and metric naming logic in some common TestMetric type
> -------------------------------------------------------------------------------------
>
> Key: BEAM-7245
> URL: https://issues.apache.org/jira/browse/BEAM-7245
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Lukasz Gajowy
> Priority: Minor
>
> After an offline discussion together with @mwalenia we decided to create concrete classes for each metric type (Item_count, byte_count, time). Each class like this will contain:
> - metric name
> - supplier for the metric
> - monitor for the metric
> It turns out that all this (along with the monitor/supplier can be encapsulated and then attached to the pipeline/metrics reading where needed. This will also encapsulate the naming logic (so that there are no typos again).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)