[PR] [runtime] Fix prune state corner cases around checkpoints [flink-agents]

["joeyutong (via GitHub)" <gi...@apache.org>]

joeyutong opened a new pull request, #603:
URL: https://github.com/apache/flink-agents/pull/603

   
   ### Purpose of change
   
   `ActionExecutionOperator` had two prune-state corner cases around checkpoints.
   
   - prune bookkeeping used `messageSequenceNumber`, which tracks the latest started sequence, not the latest completed sequence. That means an in-flight sequence could be treated as prune-safe.
   
   - the operator pruned action state as soon as a run completed. If the job later recovered from an earlier completed checkpoint, replay of the same input could no longer reuse the durable action state that had already been written.
   
   #### Fix
   
   This change makes pruning checkpoint-safe again.
   
   - track a separate `lastCompletedSequenceNumber` keyed state
   - snapshot prune metadata from `lastCompletedSequenceNumber` instead of `messageSequenceNumber`
   - remove the eager prune path on run completion
   - prune action state only after `notifyCheckpointComplete`
   
   
   ### Tests
   
   The updated tests cover:
   - no pruning before checkpoint completion
   - no pruning of sequences that are still in flight
   - replay from an earlier checkpoint keeps durable state available
   - action state cleanup happens after checkpoint completion
   
   ### API
   
   No
   
   ### Documentation
   
   <!-- Do not remove this section. Check the proper box only. -->
   
   - [ ] `doc-needed` <!-- Your PR changes impact docs -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-included` <!-- Your PR already contains the necessary documentation updates -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [runtime] Fix prune state corner cases around checkpoints [flink-agents]

["xintongsong (via GitHub)" <gi...@apache.org>]

xintongsong merged PR #603:
URL: https://github.com/apache/flink-agents/pull/603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org