You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/18 09:47:51 UTC

[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #7344: sem:change sem default behavior

anjiahao1 opened a new pull request, #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344

   Signed-off-by: anjiahao <an...@xiaomi.com>
   
   ## Summary
   [step 1](https://github.com/apache/incubator-nuttx/pull/5070)
   [step 2](https://github.com/apache/incubator-nuttx/pull/6965)
    this is step 3, remove all defult `nxsem_set_protocol` with `SEM_PRIO_NONE`,and then add it in `nxsem_init` & `nxmutex_init`
   
   ## Impact
   nothing
   ## Testing
   ostest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #7344: sem:change sem default behavior

Posted by GitBox <gi...@apache.org>.
anjiahao1 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1282338726

   this pr just remove `defult` protocl, https://github.com/apache/incubator-nuttx/pull/5070 this pr change sem   defult behavior


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] davids5 commented on pull request #7344: sem:remove sem default protocl

Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283540161

   @anjiahao1 Is there documentation added to the docs for this change documenting the new mutex and sem symantics and usage?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #7344: sem:change sem default behavior

Posted by GitBox <gi...@apache.org>.
anjiahao1 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1282158052

   > @anjiahao1 A deadlock happened with `qemu-intel64:ostest `
   > 
   > ```
   > + /home/ishikawa/opensource/QEMU/qemu-7.1/build/qemu-system-x86_64 -cpu host -enable-kvm -m 256M -cdrom boot.iso -nographic -serial mon:stdio
   > SeaBIOS (version rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org)
   > 
   > 
   > iPXE (http://ipxe.org) 00:03.0 CA00 PCI2.10 PnP PMM+0FF91160+0FEF1160 CA00
   > 
   > 
   > 
   > Booting from Hard Disk...
   > Boot failed: could not read the boot disk
   > 
   > Booting from Floppy...
   > Boot failed: could not read the boot disk
   > 
   > Booting from DVD/CD...
   > stdio_test: write fd=1
   > stdio_test: Standard I/O Check: printf
   > stdio_test: write fd=2
   > ...
   > priority_inheritance: Waiting...
   > lowpri_thread-1: Started
   > lowpri_thread-1: initial priority: 1
   > lowpri_thread-1: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > lowpri_thread-2: Started
   > lowpri_thread-2: initial priority: 1
   > lowpri_thread-2: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > lowpri_thread-3: Started
   > lowpri_thread-3: initial priority: 1
   > lowpri_thread-3: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > lowpri_thread-1: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > lowpri_thread-2: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > lowpri_thread-3: Waiting for the midle pri task to run
   >     g_middlestate:  0
   >     g_highstate[0]: 0
   >     I still have a count on the semaphore
   > priority_inheritance: Starting medpri_thread at 99
   > priority_inheritance: Set medpri_thread priority to 99
   > priority_inheritance: Waiting...
   > medpri_thread: Started ... I won't let go of the CPU!
   > priority_inheritance: Starting highpri_thread-1 (of 1) at 255
   > priority_inheritance: Set highpri_thread-1 priority to 255
   > highpri_thread-1: Started
   > priority_inheritance: Waiting for highpri_thread-1 to complete
   > highpri_thread-1: Calling sem_wait()
   > Traceback (most recent call last):
   > ```
   
   ok,i check it now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #7344: sem:remove sem default protocl

Posted by GitBox <gi...@apache.org>.
anjiahao1 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283553344

   use https://github.com/apache/incubator-nuttx/pull/5070 to submit  patch,so close current PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7344: sem:remove sem default protocl

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283452196

   let move this patch to the pr#5070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7344: sem:change sem default behavior

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283133840

   >@masayuki2009 https://github.com/apache/incubator-nuttx-apps/pull/1358 this is fix patch
   
   @anjiahao1 
   Please update the impact in the summary.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #7344: sem:change sem default behavior

Posted by GitBox <gi...@apache.org>.
anjiahao1 commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1282307419

   @masayuki2009 https://github.com/apache/incubator-nuttx-apps/pull/1358 this is fix patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7344: sem:change sem default behavior

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7344:
URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1282925127

   @xiaoxiang781216 sorry, but where the sem default behaviour is changed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anjiahao1 closed pull request #7344: sem:remove sem default protocl

Posted by GitBox <gi...@apache.org>.
anjiahao1 closed pull request #7344: sem:remove sem default protocl
URL: https://github.com/apache/incubator-nuttx/pull/7344


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org