You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/05 09:56:13 UTC
[GitHub] [flink] leonardBang opened a new pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
leonardBang opened a new pull request #12502:
URL: https://github.com/apache/flink/pull/12502
## What is the purpose of the change
* We support Create/Drop/DESCRIBE view in 1.11. this pull request Add documentation about view support.
## Brief change log
- *Add Create/Drop/DESCRIBE view section in SQL documentation*
- *Translate corresponding Chinese documentation*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12502:
URL: https://github.com/apache/flink/pull/12502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
}, {
"hash" : "fb4d094c78157b295871130018af576e347340dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4d094c78157b295871130018af576e347340dc",
"triggerType" : "PUSH"
}, {
"hash" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911",
"triggerID" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902)
* fb4d094c78157b295871130018af576e347340dc UNKNOWN
* 8bdc079d769fd6ba4640f7d31cb87b9286bfa84b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12502:
URL: https://github.com/apache/flink/pull/12502#discussion_r436462904
##########
File path: docs/dev/table/sql/queries.zh.md
##########
@@ -326,11 +326,11 @@ SHOW VIEWS;
<span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
</td>
<td>
- <p>描述给定表的元数据.</p>
+ <p>描述给定表的模式.</p>
Review comment:
use `Schema` instead of `模式` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12502:
URL: https://github.com/apache/flink/pull/12502#discussion_r436441360
##########
File path: docs/dev/table/sql/drop.md
##########
@@ -143,6 +144,22 @@ Dropping a non-empty database triggers an exception. Enabled by default.
Dropping a non-empty database also drops all associated tables and functions.
+## DROP VIEW
+
+{% highlight sql %}
+DROP [TEMPORARY] VIEW [ IF EXISTS ] view_name
Review comment:
ditto
##########
File path: docs/dev/table/sql/create.md
##########
@@ -351,6 +352,25 @@ The key and value of expression `key1=val1` should both be string literal.
{% top %}
+## CREATE VIEW
+{% highlight sql %}
+CREATE [TEMPORARY] VIEW [IF NOT EXISTS] view_name
Review comment:
CREATE [TEMPORARY] VIEW [IF NOT EXISTS] [catalog_name.][db_name.]view_name
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -344,6 +345,25 @@ CREATE DATABASE [IF NOT EXISTS] [catalog_name.]db_name
{% top %}
+## CREATE VIEW
+{% highlight sql %}
+CREATE [TEMPORARY] VIEW [IF NOT EXISTS] view_name
Review comment:
ditto
##########
File path: docs/dev/table/sql/drop.zh.md
##########
@@ -143,6 +144,22 @@ DROP DATABASE [IF EXISTS] [catalog_name.]db_name [ (RESTRICT | CASCADE) ]
删除一个非空数据库时，把相关联的表与函数一并删除。
+## DROP VIEW
+
+{% highlight sql %}
+DROP [TEMPORARY] VIEW [ IF EXISTS ] view_name
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12502:
URL: https://github.com/apache/flink/pull/12502#discussion_r436464843
##########
File path: docs/dev/table/sql/queries.zh.md
##########
@@ -326,11 +326,11 @@ SHOW VIEWS;
<span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
</td>
<td>
- <p>描述给定表的元数据.</p>
+ <p>描述给定表的模式.</p>
Review comment:
Using Schema...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12502:
URL: https://github.com/apache/flink/pull/12502#discussion_r436439900
##########
File path: docs/dev/table/sql/queries.zh.md
##########
@@ -313,9 +313,29 @@ SHOW DATABASES;
<p>显示当前数据库、Catalog中的所有表</p>
{% highlight sql %}
SHOW TABLES;
+{% endhighlight %}
+ <p>显示当前数据库、Catalog中的所有视图</p>
+{% highlight sql %}
+SHOW VIEWS;
{% endhighlight %}
</td>
</tr>
+ <tr>
+ <td>
+ <strong>Describe</strong><br>
+ <span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
+ </td>
+ <td>
+ <p>描述给定表的元数据.</p>
Review comment:
currently, only support describing table schema
##########
File path: docs/dev/table/sql/drop.md
##########
@@ -143,6 +144,22 @@ Dropping a non-empty database triggers an exception. Enabled by default.
Dropping a non-empty database also drops all associated tables and functions.
+## DROP VIEW
+
+{% highlight sql %}
+DROP [TEMPORARY] VIEW [ IF EXISTS ] view_name
+{% endhighlight %}
+
+Drop a view that has catalog and database namespaces. If the view to drop does not exist, an exception is thrown.
+
+**IF EXISTS**
+
+If the view does not exist, nothing happens.
+
+**TEMPORARY**
Review comment:
move this section to the front of **IF EXISTS**
##########
File path: docs/dev/table/sql/drop.zh.md
##########
@@ -143,6 +144,22 @@ DROP DATABASE [IF EXISTS] [catalog_name.]db_name [ (RESTRICT | CASCADE) ]
删除一个非空数据库时，把相关联的表与函数一并删除。
+## DROP VIEW
+
+{% highlight sql %}
+DROP [TEMPORARY] VIEW [ IF EXISTS ] view_name
+{% endhighlight %}
+
+删除一个有 catalog 和数据库命名空间的视图。若需要删除的视图不存在，则会产生异常。
+
+**IF EXISTS**
+
+若视图不存在，则不会进行任何操作。
+
+**TEMPORARY**
Review comment:
ditto
##########
File path: docs/dev/table/sql/queries.md
##########
@@ -313,9 +313,29 @@ SHOW DATABASES;
<p>Show all tables in the current database in the current catalog</p>
{% highlight sql %}
SHOW TABLES;
+{% endhighlight %}
+ <p>Show all views in the current database in the current catalog</p>
+{% highlight sql %}
+SHOW VIEWS;
{% endhighlight %}
</td>
</tr>
+ <tr>
+ <td>
+ <strong>Describe</strong><br>
+ <span class="label label-primary">Batch</span> <span class="label label-primary">Streaming</span>
+ </td>
+ <td>
+ <p>Describe the given table.</p>
Review comment:
explain more about `Describe` operation ? such as `Describe the schema of the given table.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-640399165
I think it's better we can explain more about the behavior of dependencies maintaining, such as: does `drop a table` operation affect a existing view ? (see https://cwiki.apache.org/confluence/display/FLINK/FLIP-71%3A+E2E+View+support+in+FLINK+SQL)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
}, {
"hash" : "fb4d094c78157b295871130018af576e347340dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4d094c78157b295871130018af576e347340dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902)
* fb4d094c78157b295871130018af576e347340dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
}, {
"hash" : "fb4d094c78157b295871130018af576e347340dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4d094c78157b295871130018af576e347340dc",
"triggerType" : "PUSH"
}, {
"hash" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902)
* fb4d094c78157b295871130018af576e347340dc UNKNOWN
* 8bdc079d769fd6ba4640f7d31cb87b9286bfa84b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
}, {
"hash" : "fb4d094c78157b295871130018af576e347340dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4d094c78157b295871130018af576e347340dc",
"triggerType" : "PUSH"
}, {
"hash" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911",
"triggerID" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb4d094c78157b295871130018af576e347340dc UNKNOWN
* 8bdc079d769fd6ba4640f7d31cb87b9286bfa84b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12502:
URL: https://github.com/apache/flink/pull/12502#discussion_r436463851
##########
File path: docs/dev/table/sql/queries.zh.md
##########
@@ -326,11 +326,11 @@ SHOW VIEWS;
<span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
</td>
<td>
- <p>描述给定表的元数据.</p>
+ <p>描述给定表的模式.</p>
Review comment:
I’m fine to use **Schema** or **模式**, because terminology **schema** can translate to **模式** in DB area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816)
* ccb02f2cef322ba37717d82afb68163d74db29f4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639384120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2816",
"triggerID" : "b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2",
"triggerType" : "PUSH"
}, {
"hash" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895",
"triggerID" : "ccb02f2cef322ba37717d82afb68163d74db29f4",
"triggerType" : "PUSH"
}, {
"hash" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902",
"triggerID" : "e4e7c48e08b874587aab3ce798c9bf3e5b2ac761",
"triggerType" : "PUSH"
}, {
"hash" : "fb4d094c78157b295871130018af576e347340dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4d094c78157b295871130018af576e347340dc",
"triggerType" : "PUSH"
}, {
"hash" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911",
"triggerID" : "8bdc079d769fd6ba4640f7d31cb87b9286bfa84b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccb02f2cef322ba37717d82afb68163d74db29f4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2895)
* e4e7c48e08b874587aab3ce798c9bf3e5b2ac761 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2902)
* fb4d094c78157b295871130018af576e347340dc UNKNOWN
* 8bdc079d769fd6ba4640f7d31cb87b9286bfa84b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2911)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12502: [FLINK-17635][docs][table sql / api] Add documentation about view support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12502:
URL: https://github.com/apache/flink/pull/12502#issuecomment-639380426
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b4fd9c461675a81e89ae4af2706bc68bfc5ae7d2 (Fri Jun 05 09:58:26 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org