You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 10:12:24 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17669: [fix][doc] Fix M1 JVM Installation Instructions

tisonkun commented on code in PR #17669:
URL: https://github.com/apache/pulsar/pull/17669#discussion_r971799555


##########
README.md:
##########
@@ -138,6 +138,47 @@ Requirements:
 > Note: this project includes a [Maven Wrapper](https://maven.apache.org/wrapper/) that can be used instead of a system installed Maven.
 > Use it by replacing `mvn` by `./mvnw` on Linux and `mvnw.cmd` on Windows in the commands below.
 
+### Install JDK on M1

Review Comment:
   I wrote:
   
   ```
   "how to install JDK on M1" is not suitable to document on the Get Started page. Imagine that you don't tell users how to buy a computer. It's far away from Pulsar topics. Users can resolve it with Google, StackOverflow, etc.
   ```
   
   in https://github.com/apache/pulsar/issues/17409#issuecomment-1236839244. This stands for README.md also. I can image users have multiple approach to do this and we don't have to use forty lines for it. If someone asked, we resolve the discuss or issue. And followers should be able to search or we simply answer by throwing the link.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org