You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Igor Fedorenko (Created) (JIRA)" <ji...@apache.org> on 2011/12/05 00:02:39 UTC
[jira] [Created] (FELIX-3254) manifest goal generates work
Export-Package when Embed-Dependency
manifest goal generates work Export-Package when Embed-Dependency
-----------------------------------------------------------------
Key: FELIX-3254
URL: https://issues.apache.org/jira/browse/FELIX-3254
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.3.6
Reporter: Igor Fedorenko
manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3254) manifest goal generates work
Export-Package when Embed-Dependency
Posted by "Igor Fedorenko (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Fedorenko updated FELIX-3254:
----------------------------------
Attachment: FELIX-3254.zip
Attached FELIX-3254.zip is a sample project to demonstrate the problem
Generated bundle manifest is expected to have
{noformat}
Export-Package: de.pdark.decentxml;version="1.3",de.pdark.decentxml.dt
d;version="1.3",de.pdark.decentxml.validation;version="1.3"
{noformat}
This works with maven-bundle-plugin 2.3.5, but with 2.3.6 generated bundle manifest does not have Export-Package at all
> manifest goal generates work Export-Package when Embed-Dependency
> -----------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3254) manifest goal generates work
Export-Package when Embed-Dependency
Posted by "Stuart McCulloch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162511#comment-13162511 ]
Stuart McCulloch commented on FELIX-3254:
-----------------------------------------
If it is related to FELIX-3206 (which actually fixes a previous regression wrt. the behaviour of the manifest goal) then it sounds like you need bnd to do a full rebuild of the bundle when creating the manifest (so bnd can fully analyze the embedded/merged content) in which case you can simply add <rebuildBundle>true</rebuildBundle> to the configuration to get the pre-FELIX-3206 behaviour.
Note that FELIX-3206 is unlikely to be reverted since there are valid use-cases when you don't want to rebuild the bundle in memory, and this was the original behaviour.
> manifest goal generates work Export-Package when Embed-Dependency
> -----------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3254) manifest goal generates wrong
Export-Package when Embed-Dependency
Posted by "Stuart McCulloch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162522#comment-13162522 ]
Stuart McCulloch commented on FELIX-3254:
-----------------------------------------
Confirmed that the rebuildBundle setting:
<configuration>
<rebuildBundle>true</rebuildBundle>
<instructions>
<!-- ... -->
</instructions>
</configuration>
works and should be used for this use-case.
The original behaviour of the manifest goal (ie. long before 2.3.4 and FELIX-2817) was to take the content of the attached file (or target/classes) and generate a manifest based on that, and that only. The use-case was that you created the content by some other means (ie. not using Embed-Dependency, etc.) and wanted a manifest based on that content. A slightly different use-case came up in FELIX-2817 where people wanted the exact same results as doing bundle:bundle (which does an in-memory build) when they created the manifest - this is the same use-case as the attached project.
There's no solution that I know of which can accommodate both use-cases with the same goal - which is why the flag (rebuildBundle) was added to switch between the 'analyzer' approach that is quick and means you don't have to match the instructions with the content (but it doesn't handle all the Include-Resource instructions) and the 'builder' approach which does a full analysis but means your instructions must describe the content of the bundle.
We could add a warning if people use instructions that don't make sense with rebuildBundle=false - I think that's better than trying to guesstimate the right setting.
> manifest goal generates wrong Export-Package when Embed-Dependency
> ------------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3254) manifest goal generates wrong
Export-Package when Embed-Dependency
Posted by "Igor Fedorenko (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Fedorenko updated FELIX-3254:
----------------------------------
Summary: manifest goal generates wrong Export-Package when Embed-Dependency (was: manifest goal generates work Export-Package when Embed-Dependency)
> manifest goal generates wrong Export-Package when Embed-Dependency
> ------------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3254) manifest goal generates work
Export-Package when Embed-Dependency
Posted by "Igor Fedorenko (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162516#comment-13162516 ]
Igor Fedorenko commented on FELIX-3254:
---------------------------------------
I am not asking to revert FELIX-3206. m-b-p should be able to generate correct manifest for the attached project or at very least fail fast and with a clear error message.
> manifest goal generates work Export-Package when Embed-Dependency
> -----------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (FELIX-3254) manifest goal generates wrong
Export-Package when Embed-Dependency
Posted by "Stuart McCulloch (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stuart McCulloch closed FELIX-3254.
-----------------------------------
Resolution: Fixed
Fix Version/s: maven-bundle-plugin-2.3.7
Assignee: Stuart McCulloch
Fixed in r1243117 - if we're generating a manifest for the output directory and there is an Embed-Dependency instruction then we can safely assume that we need to build the bundle in-memory to get the correct result.
> manifest goal generates wrong Export-Package when Embed-Dependency
> ------------------------------------------------------------------
>
> Key: FELIX-3254
> URL: https://issues.apache.org/jira/browse/FELIX-3254
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.6
> Reporter: Igor Fedorenko
> Assignee: Stuart McCulloch
> Fix For: maven-bundle-plugin-2.3.7
>
> Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira