You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/23 07:55:51 UTC
[GitHub] [james-project] chibenwa opened a new pull request #454: [PERFORMANCE] AmqpForwardAttribute should reuse connection
chibenwa opened a new pull request #454:
URL: https://github.com/apache/james-project/pull/454
Today one connection and one channel is opened per processed
emails. Connections and channels are long lived objects,
made to be reused.
Flame graphs showed that this AMQP mailet represents ~1%
of CPU occupation with just about 30 mail/sec. Note that
92% of this time is used opening/closing connections/channels.
Moving connection and channel initialization at mailet
initialization enables reuse and leads to dramatic enhancements
of the performances of that very mailet. Note that retries are
in place in case Rabbit is not up right at start - common with
IE docker-compose.
The testing strategy relying on mocks is brittle. Given that we
have full-fledged integration tests in place, we can get rid of
these annoying mock-based tests.
## Before
## After
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #454: [PERFORMANCE] AmqpForwardAttribute should reuse connection
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #454:
URL: https://github.com/apache/james-project/pull/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #454: [PERFORMANCE] AmqpForwardAttribute should reuse connection
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #454:
URL: https://github.com/apache/james-project/pull/454#issuecomment-846561562
AMQP channels are not threadsafe and should not be shared across thread.
- [ ] We should create a new `mailet-amqp` maven project
- [ ] Depends on `bckens-rabbitmq` to reuse `SimpleConnectionPool` and `ReactorRabbitMQChannelPool`
- [ ] Clean up AMQP dependency out of `mailet-standard`
- [ ] Finally we should take care that we should be able to maintain a separated AMQP host than the main one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #454: [PERFORMANCE] AmqpForwardAttribute should reuse connection
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #454:
URL: https://github.com/apache/james-project/pull/454#discussion_r637679086
##########
File path: pom.xml
##########
@@ -958,6 +958,11 @@
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>apache-mailet-amqp</artifactId>
Review comment:
idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org