You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "dao-jun (via GitHub)" <gi...@apache.org> on 2024/04/04 07:18:36 UTC
[PR] [admin][broker] Fix force delete subscription not working [pulsar]
dao-jun opened a new pull request, #22423:
URL: https://github.com/apache/pulsar/pull/22423
Fixes https://github.com/apache/pulsar/issues/22404
### Motivation
Fix force delete subscription not working on persistent topics.
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [admin][broker] Fix force delete subscription not working [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun merged PR #22423:
URL: https://github.com/apache/pulsar/pull/22423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [admin][broker] Fix force delete subscription not working [pulsar]
Posted by "Nowadays (via GitHub)" <gi...@apache.org>.
Nowadays commented on PR #22423:
URL: https://github.com/apache/pulsar/pull/22423#issuecomment-2573455628
Adding to what @fecet said, the Javadoc is clearly misleading, be it on close() or unsubscribe(), which both, clearly state that with the **force** flag it closes both the producers and consumers connected to said topic. (pulsar-client 3.2.2, broker 3.3.2)
Which is does not since if there is a consumer connected, the topic and subscription get auto-recreated, and unfortunately cannot disable the auto-creation through the broker.conf since we need it for another use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [admin][broker] Fix force delete subscription not working [pulsar]
Posted by "fecet (via GitHub)" <gi...@apache.org>.
fecet commented on PR #22423:
URL: https://github.com/apache/pulsar/pull/22423#issuecomment-2266684352
I still have the same issue on pulsar 3.3.1 on `apachepulsar/pulsar-all:3.3.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org