You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/04/26 18:58:22 UTC

[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on a diff in pull request #34: more changes to support scala 3

pjfanning commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/34#discussion_r1178275525


##########
src/test/scala/org/apache/pekko/persistence/dynamodb/journal/DynamoDBUtils.scala:
##########
@@ -29,15 +29,15 @@ trait DynamoDBUtils extends JournalSettingsProvider with DynamoProvider {
   val system: ActorSystem
   import system.dispatcher
 
-  override lazy val journalSettings = {
+  override val journalSettings = {

Review Comment:
   class has `import journalSettings._` and in scala 3, this can't be done if the val is lazy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org