You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rscarborough1996 (via GitHub)" <gi...@apache.org> on 2024/04/22 18:02:20 UTC
[I] Filter Input Regression [superset]
rscarborough1996 opened a new issue, #28174:
URL: https://github.com/apache/superset/issues/28174
### Bug description
Users are allowed to enter values into a filter that do not exist in the dropdown. As they type in their value, it will appear in the drop down for them to select.
In version 2.0.1, the value was always present as the user typed.
In versions 3.1.0 and 4.0.0, the select window constantly changes as the user type. As a new character is entered it will flash "no data", then SOMETIMES it will display what the user has typed. Sometimes it remains on "no data" and the user is unable to select their input.
While this is a small regression from earlier versions, there are still use cases where this is relevant. For instance (as in my case) jinja can be used to get values from filters and use it to influence the query.
### How to reproduce the bug
Try inputting a value that does not exist into a filter using version 3.1.0 or newer. Keep typing one character at a time until the window settles on "no data"
### Screenshots/recordings
These images are of the same filter, on the same dashboard. I just retyped the last number until the result did or did not show up.
### Superset version
4.0.0
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28174:
URL: https://github.com/apache/superset/issues/28174#issuecomment-5028971917
#35218 already has a fix in progress for this. It needs a rebase and the review feedback addressed before it can land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "rscarborough1996 (via GitHub)" <gi...@apache.org>.
rscarborough1996 commented on issue #28174:
URL: https://github.com/apache/superset/issues/28174#issuecomment-2770255693
I tested this on 5.0.0rc2 and the issue is still there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28174:
URL: https://github.com/apache/superset/issues/28174#issuecomment-3068357026
PR welcome... not sure if the 5.0 final release or any fixes present on `master` have resolved this, by some stroke of luck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28174:
URL: https://github.com/apache/superset/issues/28174#issuecomment-4597075589
Requested changes on the linked PR, hopefully we can close this one out soon :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28174:
URL: https://github.com/apache/superset/issues/28174#issuecomment-2734970580
Is this still the case in 4.1.1 or the 5.0.0 release candidate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Filter Input Regression [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 closed issue #28174: Filter Input Regression
URL: https://github.com/apache/superset/issues/28174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org