You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/05 09:50:28 UTC

Review Request 38989: Update docker-containerizer.md.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Update docker-containerizer.md.


Diffs
-----

  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/38989/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 38989: Update docker-containerizer.md.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107696
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38989: Update docker-containerizer.md.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107702
-----------------------------------------------------------


Bad patch!

Reviews applied: [38989]

Failed command: ./support/apply-review.sh -n -r 38989

Error:
 2015-11-24 02:02:06 URL:https://reviews.apache.org/r/38989/diff/raw/ [4199/4199] -> "38989.patch" [1]
error: patch failed: docs/docker-containerizer.md:14
error: docs/docker-containerizer.md: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38989: Update docker-containerizer.md.

Posted by haosdent huang <ha...@gmail.com>.

> On Nov. 24, 2015, 1:26 a.m., Timothy Chen wrote:
> > Can you rebase your patch?

Hi, @tnachen. Thanks for you reviews. After rebase, I find all my changes have been fixed in current document. So let me discard this patch.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107697
-----------------------------------------------------------


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38989: Update docker-containerizer.md.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107697
-----------------------------------------------------------


Can you rebase your patch?

- Timothy Chen


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>