You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/02 13:17:31 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32749: [SPARK-34943] Upgrade flake8 to 3.8.0 or above in Jenkins
HyukjinKwon commented on a change in pull request #32749:
URL: https://github.com/apache/spark/pull/32749#discussion_r643951833
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -361,7 +361,7 @@ jobs:
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
- python3.6 -m pip install flake8 'sphinx<3.1.0' numpy pydata_sphinx_theme ipython nbsphinx mypy numpydoc 'jinja2<3.0.0'
+ python3.6 -m pip install flake8==3.8.0 'sphinx<3.1.0' numpy pydata_sphinx_theme ipython nbsphinx mypy numpydoc 'jinja2<3.0.0'
Review comment:
I think we don't have to pin the version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org