You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2012/08/01 14:23:02 UTC

[jira] [Created] (SLING-2551) JarExecutor should obey JAVA_HOME

Robert Munteanu created SLING-2551:
--------------------------------------

             Summary: JarExecutor should obey JAVA_HOME
                 Key: SLING-2551
                 URL: https://issues.apache.org/jira/browse/SLING-2551
             Project: Sling
          Issue Type: Improvement
          Components: Testing
            Reporter: Robert Munteanu
            Priority: Minor


o.a.s.testing.tools.jarexec.JarExecutor only takes the OS into account when building the path to the java executable. 

In my case, 'java' points to Java 7 and Sling does not start yet on Java 7, so I launch the Maven build with the JAVA_HOME set to a Java 6 SDK, but the JarExecutor does not obey that and the integration tests fail to run.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SLING-2551) JarExecutor should obey JAVA_HOME

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436745#comment-13436745 ] 

Robert Munteanu commented on SLING-2551:
----------------------------------------

I agree, it makes more sense to configure the java executable.
                
> JarExecutor should obey JAVA_HOME
> ---------------------------------
>
>                 Key: SLING-2551
>                 URL: https://issues.apache.org/jira/browse/SLING-2551
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Robert Munteanu
>            Priority: Minor
>
> o.a.s.testing.tools.jarexec.JarExecutor only takes the OS into account when building the path to the java executable. 
> In my case, 'java' points to Java 7 and Sling does not start yet on Java 7, so I launch the Maven build with the JAVA_HOME set to a Java 6 SDK, but the JarExecutor does not obey that and the integration tests fail to run.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (SLING-2551) JarExecutor should obey JAVA_HOME

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu resolved SLING-2551.
------------------------------------

    Resolution: Won't Fix

Won't fix , see discussion on SLING-2682
                
> JarExecutor should obey JAVA_HOME
> ---------------------------------
>
>                 Key: SLING-2551
>                 URL: https://issues.apache.org/jira/browse/SLING-2551
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Robert Munteanu
>            Priority: Minor
>
> o.a.s.testing.tools.jarexec.JarExecutor only takes the OS into account when building the path to the java executable. 
> In my case, 'java' points to Java 7 and Sling does not start yet on Java 7, so I launch the Maven build with the JAVA_HOME set to a Java 6 SDK, but the JarExecutor does not obey that and the integration tests fail to run.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2551) JarExecutor should obey JAVA_HOME

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427948#comment-13427948 ] 

Bertrand Delacretaz commented on SLING-2551:
--------------------------------------------

Wouldn't it be better to simply make javaExecutable configurable, as with the other execution options? 

That would have less moving parts, and you can always derive the configured value from JAVA_HOME if needed.
                
> JarExecutor should obey JAVA_HOME
> ---------------------------------
>
>                 Key: SLING-2551
>                 URL: https://issues.apache.org/jira/browse/SLING-2551
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Robert Munteanu
>            Priority: Minor
>
> o.a.s.testing.tools.jarexec.JarExecutor only takes the OS into account when building the path to the java executable. 
> In my case, 'java' points to Java 7 and Sling does not start yet on Java 7, so I launch the Maven build with the JAVA_HOME set to a Java 6 SDK, but the JarExecutor does not obey that and the integration tests fail to run.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira