You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/08 08:40:01 UTC

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #772: HDDS-3335. Recon unit tests cleanup.

adoroszlai commented on a change in pull request #772: HDDS-3335. Recon unit tests cleanup.
URL: https://github.com/apache/hadoop-ozone/pull/772#discussion_r405350140
 
 

 ##########
 File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestMissingContainerTask.java
 ##########
 @@ -93,12 +82,13 @@ public void testRun() throws Exception {
     when(containerManagerMock.getContainerReplicas(new ContainerID(3L)))
         .thenReturn(Collections.emptySet());
 
-    List<MissingContainers> all = missingContainersTableHandle.findAll();
+    MissingContainersDao missingContainersDao =
+        getDao(MissingContainersDao.class);
+    List<MissingContainers> all = missingContainersDao.findAll();
 
 Review comment:
   Do we need to get the dao again?  `missingContainersTableHandle` already has an instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org