You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xli1996 (via GitHub)" <gi...@apache.org> on 2025/11/21 19:27:26 UTC
[I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
xli1996 opened a new issue, #335:
URL: https://github.com/apache/flink-agents/issues/335
### Search before asking
- [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar.
### Description
Flink agents has built-in chroma db support for both local and server in https://github.com/apache/flink-agents/pull/165.
There is a community java client https://github.com/amikos-tech/chromadb-java-client seems well supported, so we support better local dev experience for java as well.
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3988029356
Good questions. Here are my two cents:
> Language precedence: When should the base implementation live in Java vs Python? (intentional decision, rather than which ever was implemented first)
I think it depends on the sdk supports of the integrating system. If sdk is only provided for one language, or provided in both languages but one is more mature than the other, we should choose the language with better supports. Otherwise, if sdk is provided for both language with equal maturity, I'd be fine with either language.
> Native implementation: When should we implement natively in both languages vs reuse one through the bridge?
Cross-language resource access currently has a limitation of not supporting async execution, because of a bug in the upstream project pemja, which we are trying to fix next. Once this is resolved, I don't see a necessity in providing native implementation for both languages.
Another point worth considering is the performance issue. The overhead of cross-language interactions may affects the performance. However, since currently the performance bottleneck is apparently in calling the LLMs, it's probably too early to worry about the cross-language overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3580242585
Thanks for volunteering, @twosom. Since @xli1996 didn't check the option "I'm willing to submit a PR!", I've assigned you to the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "addu390 (via GitHub)" <gi...@apache.org>.
addu390 commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3988158355
@xintongsong Agree! Had similar thoughts, thanks for the added context around not supporting async execution because of Pemja (noticed a couple of places with guards for async). Should be good to close this issue or just leave it as-is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "yanand0909 (via GitHub)" <gi...@apache.org>.
yanand0909 commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3564606673
Hi @xli1996, I can work on this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "addu390 (via GitHub)" <gi...@apache.org>.
addu390 commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3979014411
@xintongsong I see the issue already assigned, incase it's abandoned, I can take this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3981838091
I think this was proposed quite early, when we didn't have the cross-language supports and had to implement an integration support twice in java and python. Now with the cross-language supports in flink agents 0.2, do we still need this? What are the unique values of providing a java native chroma support that cannot be delivered by leveraging the python implementation from the java side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "twosom (via GitHub)" <gi...@apache.org>.
twosom commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3578783040
Hi @xli1996 . can i take this PR?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [integration] [Java] Chroma vector store for Java [flink-agents]
Posted by "addu390 (via GitHub)" <gi...@apache.org>.
addu390 commented on issue #335:
URL: https://github.com/apache/flink-agents/issues/335#issuecomment-3984301930
@xintongsong Hmm, I don't see much of a drastic advantage we'd get from Java native support here. However, as we lean more on cross-language support, it raises a broader question:
- Language precedence: When should the base implementation live in Java vs Python? (intentional decision, rather than which ever was implemented first)
- Native implementation: When should we implement natively in both languages vs reuse one through the bridge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org