You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/22 15:34:07 UTC
[GitHub] [cordova-plugin-camera] exxbrain opened a new pull request #551:
Fix UI API called on a background thread (#550, #530)
exxbrain opened a new pull request #551: Fix UI API called on a background thread (#550, #530)
URL: https://github.com/apache/cordova-plugin-camera/pull/551
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
It fixes issues #530, #550 (UI API called on a background thread)
### Description
<!-- Describe your changes in detail -->
The plugin is now initializes picker in the main thread.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I've launched my app and tried to start camera session. It is now ok: now exceptions or low speed.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] exxbrain edited a comment on issue #551:
Fix UI API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577692062
> Also I believe this PR will address #447 as well, please confirm for me.
Yes. Thanks you. I added it to the description as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek edited a comment on issue #551:
Fix UI API called on a background thread (#550, #530)
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on issue #551: Fix UI API called on a background thread (#550, #530)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577669631
Thanks for the PR. Seems like there was a lot of confusion here for managing these tickets, between issues being closed prematurely even an existing PR was closed prematurely...
For github to recognise which issues this PR resolves, please edit it so it includes "fixes <issue>", note that you need to repeat this format for each issue
```
fixes #issue
fixes #issue
```
See https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords for more information.
Also I believe this PR will address https://github.com/apache/cordova-plugin-camera/issues/447 as well, please confirm for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] stevenleija commented on issue #551: Fix UI
API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
stevenleija commented on issue #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-589666200
When is this update expected to be released?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] exxbrain commented on issue #551: Fix UI
API called on a background thread (#550, #530)
Posted by GitBox <gi...@apache.org>.
exxbrain commented on issue #551: Fix UI API called on a background thread (#550, #530)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577692062
> Also I believe this PR will address #447 as well, please confirm for me.
Yes. Thanks you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] exxbrain edited a comment on issue #551:
Fix UI API called on a background thread (#550, #530)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #551: Fix UI API called on a background thread (#550, #530)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577692062
> Also I believe this PR will address #447 as well, please confirm for me.
Yes. Thanks you. I added this to the description as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on issue #551: Fix UI
API called on a background thread (#550, #530)
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #551: Fix UI API called on a background thread (#550, #530)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577669631
Thanks for the PR. Seems like there was a lot of confusion here for managing these tickets, between issues being closed prematurely, and PRs being made but not for the apache repo, etc.
For github to recognise which issues this PR resolves, please edit it so it includes "fixes <issue>", note that you need to repeat this format for each issue
```
fixes #issue
fixes #issue
```
See https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] gvsakhil commented on issue #551: Fix UI
API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
gvsakhil commented on issue #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-611472158
Please merge these fixes as this camera delay opening is a real trouble making in may devices
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] timbru31 merged pull request #551: Fix UI
API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] exxbrain edited a comment on issue #551:
Fix UI API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577692062
> Also I believe this PR will address #447 as well, please confirm for me.
Yes. Thank you. I've added it to the description as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] exxbrain edited a comment on issue #551:
Fix UI API called on a background thread (#550, #530, #447)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #551: Fix UI API called on a background thread (#550, #530, #447)
URL: https://github.com/apache/cordova-plugin-camera/pull/551#issuecomment-577692062
> Also I believe this PR will address #447 as well, please confirm for me.
Yes. Thanks you. I've added it to the description as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org