[GitHub] [incubator-superset] graceguo-supercat commented on issue #9593: Re-enable table filter, fix #8273 #8683

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #9593:
URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617008945


   > Users can edit the scopes of a table chart with filter events in the dashboard's filter scope editor
   
   I am not sure you tested all **_filter related_** use cases. There are some pretty complicated logic for filter_box's and filter's scope:
   - add/remove a _filter viz_ from a dashboard, 
   - move a chart into a tab with filter scope
   - filter indicators to show what filter are applied and by which filter component.
   - more...
   
   I want to make table filter as simple as possible, otherwise it's really hard to maintain the majority usage. I suggest:
   - Filter scope modal should not cover table filter, table filter should apply to all charts in dashboard (global scope only), 
   - table filter should not be saved as default_filters in dashboard metadata
   - dashboard doesn't persist table filter's current state. for example, when you click `share dashboard` and share a shorten dashboard link, you will lose current table filter's selection.
   
   @mistercrunch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org