[GitHub] [hbase] virajjasani commented on a change in pull request #2263: HBASE-24890 The command regioninfo is not available

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2263:
URL: https://github.com/apache/hbase/pull/2263#discussion_r471590019



##########
File path: hbase-shell/src/test/ruby/hbase/admin2_test.rb
##########
@@ -435,5 +435,39 @@ def teardown
       end
     end
   end
+
+  # Tests for the `regioninfo` shell command
+  class RegionInfoTest < Test::Unit::TestCase
+    include TestHelpers
+    include HBaseConstants
+
+    def setup
+      setup_hbase
+    end
+
+    def teardown
+      shutdown
+    end
+
+    define_test "Get region info without any args" do
+      assert_raise(ArgumentError) do
+        command(:regioninfo)
+      end
+    end
+
+    define_test 'Get region info with encoded region name' do
+      output = capture_stdout { command(:regioninfo, '1588230740') }

Review comment:
       How do we know that `1588230740` region exists? Can we create a table, list_regions and then get regioninfo with this command?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org