[jira] [Commented] (CB-12930) File plugin getDirectory on windows fails on path ending with slash

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052790#comment-16052790 ] 

ASF GitHub Bot commented on CB-12930:
-------------------------------------

GitHub user giuseppelt opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/207

    CB-12930: (windows) Fix getDirectory trailing slash path

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    
    ### What does this PR do?
    Fix the issue
    
    ### What testing has been done on this change?
    Test on WP 8.1/10 and Desktop Win10
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/giuseppelt/cordova-plugin-file patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #207
    
----
commit 6555f2a9e2bbefbd464487b9aafbe5af5093a053
Author: giuseppelt <gi...@users.noreply.github.com>
Date:   2017-06-17T10:11:55Z

    Fix getDirectory trailing slash path

----


> File plugin getDirectory on windows fails on path ending with slash
> -------------------------------------------------------------------
>
>                 Key: CB-12930
>                 URL: https://issues.apache.org/jira/browse/CB-12930
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>            Reporter: Giuseppe La Torre
>            Priority: Minor
>
> On Windows, getDirectory with a path ending with '/' fails.
> On all other platform it works as intended.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org