[jira] [Commented] (MPLUGIN-410) Create implementation attribute for @Parameter as it exists for javadoc @parameter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPLUGIN-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570719#comment-17570719 ] 

ASF GitHub Bot commented on MPLUGIN-410:
----------------------------------------

michael-o commented on code in PR #126:
URL: https://github.com/apache/maven-plugin-tools/pull/126#discussion_r928564204


##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -72,6 +72,13 @@
      */
     String defaultValue() default "";
 
+    /**
+     * Defines the implementation in the case the parameter type is an interface.
+     *
+     * @return the implementation class name
+     */
+    Class<?> implementation() default Object.class;

Review Comment:
   Question: what if the class will only be available at runtime by the user, how can it be provided here? The previous code used strings, no?





> Create implementation attribute for @Parameter as it exists for javadoc @parameter
> ----------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-410
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-410
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: maven-plugin-tools-annotations
>            Reporter: Herve Boutemy
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.7.0
>
>
> it exists in javadoc annotations: https://maven.apache.org/plugin-tools/maven-plugin-tools-java/ (line 33)
> that goes into plugin.xml descriptor https://maven.apache.org/ref/3.8.6/maven-plugin-api/plugin.html (line 44)
> but was forgotten in Java 5 annotations: https://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/ (line 44)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)