You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/05/09 19:15:28 UTC
[kudu-CR] [build] Fix Gradle Checkstyle tasks
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13297
Change subject: [build] Fix Gradle Checkstyle tasks
......................................................................
[build] Fix Gradle Checkstyle tasks
Checkstyle was broken in a recent upgrade due to
backwards incompatible changes to Checkstyle rules.
This patch adjust the Checkstyle task to be a bit more
Gradle idiomatic and also updates the checkstyle rules
to be more current.
Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
---
R java/config/checkstyle/checkstyle.xml
R java/config/checkstyle/suppressions.xml
M java/gradle/quality.gradle
3 files changed, 69 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/13297/1
--
To view, visit http://gerrit.cloudera.org:8080/13297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
Gerrit-Change-Number: 13297
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix Gradle Checkstyle tasks
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13297 )
Change subject: [build] Fix Gradle Checkstyle tasks
......................................................................
Patch Set 1:
Someone mentioned it to me. Spotbugs is broken too. We don't run gradle "check" as a part of CI because of a lot of outstanding cleanup required.
--
To view, visit http://gerrit.cloudera.org:8080/13297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
Gerrit-Change-Number: 13297
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 May 2019 20:12:19 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix Gradle Checkstyle tasks
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13297 )
Change subject: [build] Fix Gradle Checkstyle tasks
......................................................................
Patch Set 1: Code-Review+2
How did you notice it was broken?
--
To view, visit http://gerrit.cloudera.org:8080/13297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
Gerrit-Change-Number: 13297
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 May 2019 19:59:39 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix Gradle Checkstyle tasks
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13297 )
Change subject: [build] Fix Gradle Checkstyle tasks
......................................................................
[build] Fix Gradle Checkstyle tasks
Checkstyle was broken in a recent upgrade due to
backwards incompatible changes to Checkstyle rules.
This patch adjust the Checkstyle task to be a bit more
Gradle idiomatic and also updates the checkstyle rules
to be more current.
Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
Reviewed-on: http://gerrit.cloudera.org:8080/13297
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
R java/config/checkstyle/checkstyle.xml
R java/config/checkstyle/suppressions.xml
M java/gradle/quality.gradle
3 files changed, 69 insertions(+), 30 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f4d3aac746240949a32c798e27cd708a77966a4
Gerrit-Change-Number: 13297
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)