You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/22 19:37:50 UTC
[GitHub] [incubator-druid] himanshug commented on a change in pull request
#7728: fix Select query fails with columns called "timestamp" bug
himanshug commented on a change in pull request #7728: fix Select query fails with columns called "timestamp" bug
URL: https://github.com/apache/incubator-druid/pull/7728#discussion_r286641405
##########
File path: processing/src/main/java/org/apache/druid/query/select/EventHolder.java
##########
@@ -32,7 +32,7 @@
*/
public class EventHolder
{
- public static final String timestampKey = "timestamp";
+ public static final String timestampKey = "__time";
Review comment:
well... it was a "documented feature", so documentation for select query needs to be updated as well and please add release notes in the PR description which need to be added to the release notes where this will go as someone might be using the key "timestamp".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org