You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/02/01 00:09:36 UTC
[GitHub] [hadoop] omalley commented on a change in pull request #3950: HADOOP-18100: Change scope of inner classes in InodeTree to make them accessible outside package
omalley commented on a change in pull request #3950:
URL: https://github.com/apache/hadoop/pull/3950#discussion_r796168022
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
##########
@@ -102,7 +102,7 @@ protected Path fullPath(final Path path) {
* @param uri base uri
* @throws IOException
*/
- ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
+ public ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
Review comment:
Why is this public instead of protected?
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
##########
@@ -102,7 +102,7 @@ protected Path fullPath(final Path path) {
* @param uri base uri
* @throws IOException
*/
- ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
+ public ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
Review comment:
The same applies to the rest of the private to public changes.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/FsGetter.java
##########
@@ -20,15 +20,15 @@
import java.io.IOException;
import java.net.URI;
-import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
/**
* File system instance getter.
*/
-@Private
-class FsGetter {
+@InterfaceAudience.Public
Review comment:
I'd be far happier with LimitedPrivate here. Certainly, you should also add an Evolving annotation also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org