You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by GERey <gi...@git.apache.org> on 2016/05/02 23:44:33 UTC

[GitHub] usergrid pull request: Usergrid 1246

GitHub user GERey opened a pull request:

    https://github.com/apache/usergrid/pull/514

    Usergrid 1246

    This pr should be carefully reviewed. It passes all of the tests locally, but does the following things. 
    
    - Remove export / import endpoints
    - Remove jclouds dependencies
    - Remove hazelcast dependencies
    - Remove zookeeper related dependencies
    - Removed aopalliance 
    - Removed launcher and web socket modules
    - Removed older jersey apache client
    - Upgraded from apache commons 3 to apache commons4


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GERey/usergrid USERGRID-1246-MASTER

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/usergrid/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #514
    
----
commit ce162fa9feccc666b0bd9d5d218eaab49281a2c9
Author: George Reyes <gr...@apache.org>
Date:   2016-04-28T21:32:23Z

    Removal of launcher, and web sockets modules. They aren't supposed at this point in time.
    Also removed netty and hazelcast dependencies

commit 3712254ad1145e399e0b7f0faa7fcc2f81d65560
Author: George Reyes <gr...@apache.org>
Date:   2016-04-28T21:49:55Z

    Removal of mongo-emulator along with associated dependencies

commit a4d30ec526d3b16040107f06223276c528846834
Author: George Reyes <gr...@apache.org>
Date:   2016-04-28T22:01:16Z

    removed an older jersey-apache-client

commit ff9dcab75303ade4aaedf6c4b15e208d00d377d3
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T16:16:45Z

    Removed hazel cast from the pom and the files that use hazel cast for testing.
    Removing and replacing instances of commons.collection with commons.collection4

commit 01dde6fcdb9b646eda103734013815542132b002
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T17:05:23Z

    Turns out we didn't need any of the apache commons collection stuff. We only use whats in our utils so the dependency could be trimmed. Also removed erroneous mention of hazel cast in a logger.

commit cb1356c233757e81229c235b0f846713ac78b9fb
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T17:48:11Z

    Removing export and import files along with the other export that uses Jclouds

commit 7b5e7dfb2b7ecfdedab01543c2072094887a84a9
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T17:49:34Z

    Removed the export and import endpoints from the codebase.

commit ea7caca7670c72b208e2977fc147f212de0c26aa
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T18:54:52Z

    Fixed some of other collection errors in the rest/service/core layer that weren't addressed before.
    Removed export and import methods that were leftover as well.

commit ab36dd31c123005aaa84a0557800f0953524b84b
Author: George Reyes <gr...@apache.org>
Date:   2016-04-29T22:47:10Z

    Removing Jclouds from the code base along with the aopalliance dependency since it isn't used.

commit 325242e4a6eac2f9f54f7b8ea9def7e86e0df499
Author: George Reyes <gr...@apache.org>
Date:   2016-04-30T00:00:54Z

    bumped the tomcat version for compatibility with tomcat 8.
    Removed power mock as we only use mockito now
    Removed the AppleJavaExtensions since we removed the launcher as well.
    Added some comments on why some dependencies were left in.
    Removed the Cglib since we use other java byte code plugins
    Removed nexflix curator since we don't use zookeeper in the code base anymore.
    Also fixed a small call in the ToolBase for the tools since the call it used to make no longer exists.

commit 60ec5828e2e019e035af9bc6f380fa947042bf1b
Author: Dave Johnson <sn...@apache.org>
Date:   2016-04-14T23:18:07Z

    Additional tests to show how connection queries work when some entities are not indexed.

commit 6c00a1c2a76a4597d34557b13e193ea2e961baea
Author: George Reyes <gr...@apache.org>
Date:   2016-04-15T21:40:27Z

    Added the decrement call to delete so that entity counters are decremented.
    Added test proving that entity counters are decremented.

commit 12f32eb3a12e5b37d8de342502bc62320e79c4e4
Author: Dave Johnson <sn...@apache.org>
Date:   2016-04-18T12:26:37Z

    Do not add "none" to list of required fields!

commit 423c865c499dbe4bb599dadcf67a4ea905cc7376
Author: Dave Johnson <sn...@apache.org>
Date:   2016-04-20T15:02:14Z

    Ensure that applicationId cache does not cache nulls.

commit 5beb53bcb267f33a1fcab84afb70c91e8cb5e75b
Author: Dave Johnson <sn...@apache.org>
Date:   2016-04-20T18:43:06Z

    Invalidate ShiroCache when admin user added to org.

commit 69ccb1f448003b92f7185a8a81b1bb26e1354e47
Author: George Reyes <gr...@apache.org>
Date:   2016-04-20T22:50:39Z

    Added a test for counters that isn't correctly configured to work with other tests yet, and added the counters to the backend of notifications for further examination.

commit f6d2430c7509d4fbbe010fa025ff4b44213b4613
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-20T23:17:53Z

    Fix NPE.

commit 2f47ac08fee777502377f0783a2e46270c1d325e
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T01:01:57Z

    Temporarily disable notification counters and back to Schedulers.io()

commit b05933352d9068108e65f882b4e5b1a13410f4c0
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T01:24:59Z

    Fix scheduler.

commit 3c21c2c477f57210e2c17e92b78605c29a08eab4
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T01:26:48Z

    Update distinct code.

commit d1423d888b738a6bf20ef99d32c2b8a2223917bd
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T01:52:07Z

    Update distinct to properly use device ID.

commit 8b2a4b8135e09cd6a717d1b9d35062b81d81b4af
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T02:42:44Z

    Back to Schedulers.io()

commit 8887bb197c7d880a1649be75da95845ab7e9ffc7
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T02:45:56Z

    Increase AWS client timeouts.

commit e639ff8e73d90df94dcdb55f0fbbb4c399d8fd47
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-20T18:50:41Z

    Add a separate executor pool for async processing instead of unbounded Schedulers.io()

commit 8da733496df3425f3daa66808a66a6bf2c594a52
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-21T17:08:09Z

    Increase limit of device fetching per user to 50.

commit fa5b19f6d51a43dbe6046084a20d83e67ee70056
Author: Mike Dunker <md...@apigee.com>
Date:   2016-04-21T17:08:25Z

    Add status/memory endpoint to get heap usage, max heap, and free heap.

commit 14f7e29efb37996f3cd4e256bb5120656129dfcc
Author: Mike Dunker <md...@apigee.com>
Date:   2016-04-21T18:07:08Z

    Tweak heap status to return used heap, and changed endpoint to status/heap.

commit 255bba3106f64564ebc6e912794a2d153fdab05b
Author: George Reyes <gr...@apache.org>
Date:   2016-04-22T21:45:07Z

    Added fixes around caching and changed the endpoint to selective indexing to be /_index instead of /_indexes

commit 13117cab676c771d444de99a42a9957e52a347af
Author: Michael Russo <mr...@apigee.com>
Date:   2016-04-27T00:00:08Z

    Ensure the hector cluster is created with credentials from the properties file.

commit 6df86b4aeae58a3362260d1f6cd3945396ae15d2
Author: George Reyes <gr...@apache.org>
Date:   2016-04-28T21:32:23Z

    Removal of launcher, and web sockets modules. They aren't supposed at this point in time.
    Also removed netty and hazelcast dependencies

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] usergrid pull request: Usergrid 1246

Posted by GERey <gi...@git.apache.org>.
Github user GERey closed the pull request at:

    https://github.com/apache/usergrid/pull/514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] usergrid pull request: Usergrid 1246

Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:

    https://github.com/apache/usergrid/pull/514#issuecomment-217964339
  
    Agreed, I'll hold up until some of the more major changes are in master then I'll resubmit this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] usergrid pull request: Usergrid 1246

Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:

    https://github.com/apache/usergrid/pull/514#issuecomment-216375720
  
    Not sure why, but commits that are already in are showing up on this PR. It should be fine, but having some one else verify would be nice. Also it might just go away as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] usergrid pull request: Usergrid 1246

Posted by michaelarusso <gi...@git.apache.org>.
Github user michaelarusso commented on the pull request:

    https://github.com/apache/usergrid/pull/514#issuecomment-217859912
  
    Really wish the commit history on this PR wasn't so goofy. It seems like you migh have started from release-2.1.1 branch and then merged master into that, and now opened PR to master ( having things not yet merged from release-2.1.1 into master).  Can you clean this up and make a fresh PR to master, based on current master plus your commits for this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---