[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #295: Support for Mongo Java Driver 4.2+

[GitBox <gi...@apache.org>]

mreutegg commented on a change in pull request #295:
URL: https://github.com/apache/jackrabbit-oak/pull/295#discussion_r649994601



##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/MongoConnection.java
##########
@@ -27,18 +27,27 @@
 import com.mongodb.MongoException;
 import com.mongodb.ReadConcern;
 import com.mongodb.ReadConcernLevel;
+import com.mongodb.ServerAddress;
 import com.mongodb.WriteConcern;
 import com.mongodb.client.MongoDatabase;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import com.mongodb.event.ClusterListener;
+import org.apache.jackrabbit.oak.plugins.document.mongo.MongoUtils;

Review comment:
       This import is unused and can be removed.
   ```suggestion
   ```

##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoUtils.java
##########
@@ -31,18 +29,19 @@
 import com.mongodb.client.FindIterable;
 import com.mongodb.client.MongoCollection;
 import com.mongodb.client.model.IndexOptions;
-
 import org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.Type;
 import org.bson.Document;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
+import java.util.Set;
+
 import static com.google.common.base.Preconditions.checkArgument;
 
 /**
  * Provides static utility methods for MongoDB.
  */
-class MongoUtils {
+public class MongoUtils {

Review comment:
       I'm still not able to identify those tests. I'm able to build `oak-store-document` module successfully when I revert the changes on this class, that is, making it package private again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org