You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Michael Kaye (JIRA)" <ji...@apache.org> on 2008/04/22 17:47:21 UTC
[jira] Created: (WSCOMMONS-329)
org.apache.axiom.attachment.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
org.apache.axiom.attachment.Attachments#getSOAPPartContentID() does not parse content ids correctly.
----------------------------------------------------------------------------------------------------
Key: WSCOMMONS-329
URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
Project: WS-Commons
Issue Type: Bug
Components: AXIOM
Reporter: Michael Kaye
When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WSCOMMONS-329)
org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen reassigned WSCOMMONS-329:
-----------------------------------------
Assignee: Andreas Veithen
> org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Assignee: Andreas Veithen
> Fix For: Axiom 1.2.8
>
> Attachments: axiom-cid-patch, axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WSCOMMONS-329)
org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved WSCOMMONS-329.
---------------------------------------
Resolution: Fixed
I applied your patch. I've simplified a bit the unit test cases and merged them into the existing AttachmentsTest in the axiom-tests module. The fix will be available in Axiom 1.2.8. Thanks for your contribution.
> org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Assignee: Andreas Veithen
> Fix For: Axiom 1.2.8
>
> Attachments: axiom-cid-patch, axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WSCOMMONS-329)
org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen updated WSCOMMONS-329:
--------------------------------------
Fix Version/s: Axiom 1.2.8
> org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Fix For: Axiom 1.2.8
>
> Attachments: axiom-cid-patch, axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WSCOMMONS-329)
org.apache.axiom.attachment.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Michael Kaye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Kaye updated WSCOMMONS-329:
-----------------------------------
Attachment: axiom-cid-patch
Patch with test case.
> org.apache.axiom.attachment.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> ----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Attachments: axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WSCOMMONS-329)
org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Michael Kaye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Kaye updated WSCOMMONS-329:
-----------------------------------
Summary: org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly. (was: org.apache.axiom.attachment.Attachments#getSOAPPartContentID() does not parse content ids correctly.)
Typo of attachments in package name
> org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Attachments: axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WSCOMMONS-329)
org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not
parse content ids correctly.
Posted by "Michael Kaye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Kaye updated WSCOMMONS-329:
-----------------------------------
Attachment: axiom-cid-patch
The patch attached has been updated to work against 1.2.6, includes test cases and fixes the bug.
It also fixes a related bug where the length of the content id is less than 4 characters long.
> org.apache.axiom.attachments.Attachments#getSOAPPartContentID() does not parse content ids correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-329
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-329
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Michael Kaye
> Attachments: axiom-cid-patch, axiom-cid-patch
>
>
> When using org.apache.axiom.attachment.Attachments#getSOAPPartContentID(), if the content ID is in the form : "cid-12345@192.168.0.1" then the code that strips "cid:" prefixes also strips the "cid-" prefix.
> Attached is a patch containing a test case (stripped down and details obscured, so apologies if it doesn't precisely parse as a SOAP-with-attachments request) and the required fix (basically, look for all four characters, not just the first three).
> This patch is against the latest axiom I could find (1.2.5).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.