You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by aaltay <gi...@git.apache.org> on 2016/06/27 17:04:22 UTC
[GitHub] incubator-beam pull request #538: Pylint integration for Python SDK
GitHub user aaltay opened a pull request:
https://github.com/apache/incubator-beam/pull/538
Pylint integration for Python SDK
This change introduces a pylint rule to keep the code base in a consistent state. Pylint configuration is heavily influenced by the existing standards in the code. Even with this there were multiple pylint issues. In order to make this change submit locking and also affect the others minimally I made the following choices:
- Enabled line length (80 chars), and indentation rules (2 spaces, and 4 spaces after parentheses.).
- Disabled all other rules. I will work on fixing violations of those and enabling them one by one.
- Run pylint only on those files under python/sdks/apache_beam/**/*.py and that changed compared to python_sdk branch HEAD. Note that this is files changed not lines changed.
- Made it submit blocking. Travis will fail if there are lint errors.
You can install pylint (pip install pylint) and run it locally:
$ cd sdks/python
To run on all files:
$ pylint apache_beam
To run on all changed files (Diff of last commit to python-sdk branch HEAD):
$ ./run_pylint.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/incubator-beam lint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #538
----
commit 5918d7e94239de08aa7d6f50484f33c39c208ba2
Author: Ahmet Altay <al...@google.com>
Date: 2016-06-24T21:04:27Z
Pylint integration for Python SDK
Runs pylint on modified files under sdks/python/**/*.py.
commit 06380d6c5a6a9585acf1f3104992899743477c22
Author: Ahmet Altay <al...@google.com>
Date: 2016-06-24T23:00:01Z
Fix line-too-long pylint warnings.
commit 7e4d01f48baef9e2c734704f446bd3708198280f
Author: Ahmet Altay <al...@google.com>
Date: 2016-06-24T23:32:46Z
Fix bad-continuation lint warnings.
commit 6d55a33903ab19f2d97908b0003758d16dc119da
Author: Ahmet Altay <al...@google.com>
Date: 2016-06-27T16:57:18Z
Clean up pylintrc file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #538: Pylint integration for Python SDK
Posted by aaltay <gi...@git.apache.org>.
Github user aaltay closed the pull request at:
https://github.com/apache/incubator-beam/pull/538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---