You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/29 00:07:53 UTC

[GitHub] [inlong] ciscozhou commented on a diff in pull request #4802: [INLONG-4766][Manager] Fix workflow NP problem when the COMPLETE request is fired directly from client

ciscozhou commented on code in PR #4802:
URL: https://github.com/apache/inlong/pull/4802#discussion_r909092681


##########
inlong-manager/manager-workflow/src/main/java/org/apache/inlong/manager/workflow/processor/ServiceTaskProcessor.java:
##########
@@ -120,6 +121,10 @@ public boolean complete(WorkflowContext context) {
     }
 
     private void resetActionContext(WorkflowContext context) {
+        if (CollectionUtils.isEmpty(context.getNewTaskList())) {
+            // direct complete request where the action context is already present

Review Comment:
   where -> when?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org