[GitHub] [ozone] hemantk-12 commented on a diff in pull request #5201: HDDS-8665. Implemented CopyObject for SnapshotInfo and moved out snapshot chain update form OMSnapshotPurgeResponse

["hemantk-12 (via GitHub)" <gi...@apache.org>]

hemantk-12 commented on code in PR #5201:
URL: https://github.com/apache/ozone/pull/5201#discussion_r1302266450


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java:
##########
@@ -94,12 +98,16 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
         SnapshotInfo nextSnapshot = SnapshotUtils
             .getNextActiveSnapshot(fromSnapshot,
                 snapshotChainManager, omSnapshotManager);
+
         updateSnapshotInfoAndCache(nextSnapshot, omMetadataManager,
             trxnLogIndex, updatedSnapInfos, true);
+        updateSnapshotChainAndCache(omMetadataManager, fromSnapshot,

Review Comment:
   There is a possibility that snapshot chain may get corrupted because of batch operation.
   Created jira to revisit it: https://issues.apache.org/jira/browse/HDDS-9198



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org