You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/09/23 10:55:43 UTC
Re: Review Request 37997: Running PathInheritedProperties tests from
libprocess Makefile
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 10:55 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
No longer WIP opening to the community.
Summary (updated)
-----------------
Running PathInheritedProperties tests from libprocess Makefile
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description (updated)
-------
Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
Diff: https://reviews.apache.org/r/37997/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37997: Running InheritanceTree tests from
libprocess Makefile
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 1:23 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Renaming test file.
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
Diff: https://reviews.apache.org/r/37997/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37997: Running InheritanceTree tests from
libprocess Makefile
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 10:18 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Change in PathInheritedProperties -> InheritanceTree.
Summary (updated)
-----------------
Running InheritanceTree tests from libprocess Makefile
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
Diff: https://reviews.apache.org/r/37997/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 37997: Running PathInheritedProperties tests from
libprocess Makefile
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/#review100563
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Sept. 23, 2015, 1:55 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37997/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:55 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
>
> Diff: https://reviews.apache.org/r/37997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 37997: Running PathInheritedProperties tests from
libprocess Makefile
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Sept. 23, 2015, 7:38 p.m., Alex Clemmer wrote:
> > Can we add these tests to the CMakeLists.txt file in 3rdparty/libprocess/3rdparty/stout/tests/ as well?
As I mentioned it was done in a previous patch. But the stout test with autotool are ran from the libprocess Makefile which forces the commit to be split in two.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/#review100233
-----------------------------------------------------------
On Sept. 23, 2015, 10:55 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37997/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 10:55 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
>
> Diff: https://reviews.apache.org/r/37997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 37997: Running PathInheritedProperties tests from
libprocess Makefile
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37997/#review100233
-----------------------------------------------------------
Can we add these tests to the CMakeLists.txt file in 3rdparty/libprocess/3rdparty/stout/tests/ as well?
- Alex Clemmer
On Sept. 23, 2015, 8:55 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37997/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:55 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout tests are actually ran from libprocess makefile, which requires new tests to be split in two commits.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
>
> Diff: https://reviews.apache.org/r/37997/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>