You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Ryan (JIRA)" <ji...@apache.org> on 2014/08/11 04:20:11 UTC
[jira] [Closed] (SOLR-3492) Caching of
ReversedWildcardFilterFactory in SolrQueryParser looks broken
[ https://issues.apache.org/jira/browse/SOLR-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Ryan closed SOLR-3492.
------------------------------
Resolution: Fixed
Fix Version/s: 4.1
It appears this was fixed as part of SOLR-4093.
> Caching of ReversedWildcardFilterFactory in SolrQueryParser looks broken
> ------------------------------------------------------------------------
>
> Key: SOLR-3492
> URL: https://issues.apache.org/jira/browse/SOLR-3492
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.6, 4.0-ALPHA
> Reporter: Michael Ryan
> Priority: Minor
> Fix For: 4.1
>
>
> The caching of ReversedWildcardFilterFactory in SolrQueryParser looks broken.
> Here's the current code:
> {code}ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
> if (fac == null && leadingWildcards.containsKey(fac)) {
> return fac;
> }{code}
> That doesn't quite make sense - fac will never be returned, as leadingWildcards will never contain a null key. I think this is probably what was intended:
> {code}ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
> if (fac != null) {
> return fac;
> }{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org